diff --git a/app/assets/javascripts/editor/editor.js.erb b/app/assets/javascripts/editor/editor.js.erb index 8b3db444..50e14514 100644 --- a/app/assets/javascripts/editor/editor.js.erb +++ b/app/assets/javascripts/editor/editor.js.erb @@ -351,7 +351,7 @@ configureEditors: function () { }, isBrowserSupported: function () { - // websockets is used for run, score and test + // websockets are used for run, score and test return Modernizr.websockets; }, @@ -361,7 +361,7 @@ configureEditors: function () { panel.find('.panel-title .number').text(index + 1); panel.find('.row .col-sm-9').eq(0).find('.number').eq(0).text(result.passed); panel.find('.row .col-sm-9').eq(0).find('.number').eq(1).text(result.count); - panel.find('.row .col-sm-9').eq(1).find('.number').eq(0).text((result.score * result.weight).toFixed(2)); + panel.find('.row .col-sm-9').eq(1).find('.number').eq(0).text(parseFloat((result.score * result.weight).toFixed(2))); panel.find('.row .col-sm-9').eq(1).find('.number').eq(1).text(result.weight); panel.find('.row .col-sm-9').eq(2).text(result.message); if (result.error_messages) panel.find('.row .col-sm-9').eq(3).text(result.error_messages.join(', ')); diff --git a/app/assets/javascripts/editor/evaluation.js.erb b/app/assets/javascripts/editor/evaluation.js.erb index f7b51f30..e4182413 100644 --- a/app/assets/javascripts/editor/evaluation.js.erb +++ b/app/assets/javascripts/editor/evaluation.js.erb @@ -6,6 +6,7 @@ CodeOceanEditorEvaluation = { */ scoreCode: function (event) { event.preventDefault(); + this.clearScoringOutput(); this.createSubmission('#assess', null, function (response) { this.showSpinner($('#assess')); $('#score_div').removeClass('hidden'); @@ -139,6 +140,14 @@ CodeOceanEditorEvaluation = { $('#output pre').remove(); }, + clearScoringOutput: function() { + $('#results ul').first().html(''); + $('.test-count .number').html(0); + $('#score').data('score', 0); + this.renderScore(); + this.clearOutput(); + }, + printOutput: function (output, colorize, index) { var element = this.findOrCreateOutputElement(index); if (!colorize) { diff --git a/app/controllers/exercises_controller.rb b/app/controllers/exercises_controller.rb index 9668e430..e1ada974 100644 --- a/app/controllers/exercises_controller.rb +++ b/app/controllers/exercises_controller.rb @@ -265,7 +265,7 @@ class ExercisesController < ApplicationController return # else: show open rfc for same exercise if available - elsif rfc = RequestForComment.unsolved.where(exercise_id: @submission.exercise).order("RANDOM()").first + elsif rfc = RequestForComment.unsolved.where(exercise_id: @submission.exercise).where.not(question: nil).order("RANDOM()").first # set a message that informs the user that his score was perfect and help in RFC is greatly appreciated. flash[:notice] = I18n.t('exercises.submit.full_score_redirect_to_rfc') flash.keep(:notice) diff --git a/app/views/request_for_comments/show.html.erb b/app/views/request_for_comments/show.html.erb index 5ad78b58..d0fe31af 100644 --- a/app/views/request_for_comments/show.html.erb +++ b/app/views/request_for_comments/show.html.erb @@ -6,7 +6,9 @@ submission = @request_for_comment.submission %> <%= user.displayname %> | <%= @request_for_comment.created_at.localtime %> +
+