htwkmooc/codeocean
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix return value of logger being assigned to exercise

Browse Source
This commit is contained in:
Maximilian Grundke
2017-10-25 12:07:16 +02:00
parent 6d28f427d8
commit 87f280089d
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
app/models/proxy_exercise.rb
View File

@ -37,8 +37,8 @@ class ProxyExercise < ActiveRecord::Base
assigned_user_proxy_exercise.exercise assigned_user_proxy_exercise.exercise
else else
matching_exercise = matching_exercise =
Rails.logger.debug("find new matching exercise for user #{user.id}" )
begin begin
Rails.logger.debug("find new matching exercise for user #{user.id}" )
find_matching_exercise(user) find_matching_exercise(user)
rescue => e #fallback rescue => e #fallback
Rails.logger.error("finding matching exercise failed. Fall back to random exercise! Error: #{$!}" ) Rails.logger.error("finding matching exercise failed. Fall back to random exercise! Error: #{$!}" )
@ -85,8 +85,7 @@ class ProxyExercise < ActiveRecord::Base
@reason[:reason] = "easiest exercise in pool. empty potential exercises" @reason[:reason] = "easiest exercise in pool. empty potential exercises"
select_easiest_exercise(exercises) select_easiest_exercise(exercises)
else else
recommended_exercise = select_best_matching_exercise(user, exercises_user_has_accessed, potential_recommended_exercises) select_best_matching_exercise(user, exercises_user_has_accessed, potential_recommended_exercises)
recommended_exercise
end end
end end
@ -238,4 +237,4 @@ class ProxyExercise < ActiveRecord::Base
exercises.order(:expected_difficulty).first exercises.order(:expected_difficulty).first
end end
end end