htwkmooc/codeocean
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix race condition on JavaScript initializer

Browse Source 
Previously, ProgrammingGroups could have been undefined in rare cases. Therefore, we check whether the variable is properly defined before calling the method.

Fixes CODEOCEAN-FRONTEND-7D
This commit is contained in:
Sebastian Serth
2024-04-24 15:31:15 +02:00
committed by Sebastian Serth
parent 6d66376aae
commit 88c6be88f1
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/assets/javascripts/channels/synchronized_editor_channel.js
View File

@ -4,7 +4,7 @@ $(document).on('turbolinks:load', function () {
var editor = $('#editor'); var editor = $('#editor');
var exercise_id = editor.data('exercise-id'); var exercise_id = editor.data('exercise-id');
if ($.isController('exercises') && ProgrammingGroups.is_other_user(current_contributor)) { if ($.isController('exercises') && typeof ProgrammingGroups !== 'undefined' && ProgrammingGroups.is_other_user(current_contributor)) {
App.synchronized_editor = App.cable.subscriptions.create({ App.synchronized_editor = App.cable.subscriptions.create({
channel: "SynchronizedEditorChannel", exercise_id: exercise_id channel: "SynchronizedEditorChannel", exercise_id: exercise_id