Merge pull request #235 from openHPI/remove_old_hints

Completely remove old hints connected to the execution environment

app/views/code_ocean/errors/index.html.slim

@@ -1,19 +0,0 @@
-h1 = CodeOcean::Error.model_name.human(count: 2)
-
-.table-responsive
-  table.table
-    thead
-      tr
-        th = t('errors.index.count')
-        th = t('activerecord.attributes.error.message')
-        th = t('shared.created_at')
-        th = t('shared.actions')
-    tbody
-      - @errors.each do |error|
-        tr
-          td = error.count
-          td = error.message
-          td = l(error.created_at, format: :short)
-          td = link_to(t('shared.show'), execution_environment_error_path(params[:execution_environment_id], error))
-
-p = render('shared/pagination', collection: @errors)

app/views/code_ocean/errors/show.html.slim

@@ -1,4 +0,0 @@
-h1 = CodeOcean::Error.model_name.human
-
-= row(label: 'error.message', value: @error.message)
-= row(label: 'shared.created_at', value: l(@error.created_at, format: :short))

app/views/execution_environments/index.html.slim

@@ -11,7 +11,6 @@ h1 = ExecutionEnvironment.model_name.human(count: 2)
         th = t('activerecord.attributes.execution_environment.network_enabled')
         th = t('activerecord.attributes.execution_environment.permitted_execution_time')
         th colspan=5 = t('shared.actions')
-        th colspan=2 = t('shared.resources')
     tbody
       - @execution_environments.each do |execution_environment|
         tr
@@ -26,8 +25,6 @@ h1 = ExecutionEnvironment.model_name.human(count: 2)
           td = link_to(t('shared.destroy'), execution_environment, data: {confirm: t('shared.confirm_destroy')}, method: :delete)
           td = link_to(t('.shell'), shell_execution_environment_path(execution_environment))
           td = link_to(t('shared.statistics'), statistics_execution_environment_path(execution_environment))
-          td = link_to(t('activerecord.models.error.other'), execution_environment_errors_path(execution_environment.id))
-          td = link_to(t('activerecord.models.hint.other'), execution_environment_hints_path(execution_environment.id))
 
 = render('shared/pagination', collection: @execution_environments)
 p = render('shared/new_button', model: ExecutionEnvironment)

app/views/exercises/_editor.html.slim

@@ -4,7 +4,7 @@
 - show_break_interventions = @show_break_interventions || "false"
 - show_rfc_interventions = @show_rfc_interventions || "false"
 - hide_rfc_button = @hide_rfc_button || false
-#editor.row data-exercise-id=@exercise.id data-message-depleted=t('exercises.editor.depleted') data-message-timeout=t('exercises.editor.timeout',  permitted_execution_time: @exercise.execution_environment.permitted_execution_time) data-errors-url=execution_environment_errors_path(exercise.execution_environment) data-submissions-url=submissions_path data-user-id=@current_user.id data-user-external-id=external_user_external_id data-working-times-url=working_times_exercise_path(@exercise) data-intervention-save-url=intervention_exercise_path(@exercise) data-rfc-interventions=show_rfc_interventions data-break-interventions=show_break_interventions data-course_token=@course_token data-search-save-url=search_exercise_path(@exercise)
+#editor.row data-exercise-id=@exercise.id data-message-depleted=t('exercises.editor.depleted') data-message-timeout=t('exercises.editor.timeout',  permitted_execution_time: @exercise.execution_environment.permitted_execution_time) data-submissions-url=submissions_path data-user-id=@current_user.id data-user-external-id=external_user_external_id data-working-times-url=working_times_exercise_path(@exercise) data-intervention-save-url=intervention_exercise_path(@exercise) data-rfc-interventions=show_rfc_interventions data-break-interventions=show_break_interventions data-course_token=@course_token data-search-save-url=search_exercise_path(@exercise)
   div id="sidebar" class=(@exercise.hide_file_tree ? 'sidebar-col-collapsed' : 'sidebar-col') = render('editor_file_tree', exercise: @exercise, files: @files)
   div.editor-col.col.p-0 id='frames'
     #editor-buttons.btn-group.enforce-bottom-margin

app/views/exercises/_editor_output.html.slim

@@ -37,11 +37,6 @@ div.h-100 id='output_sidebar_uncollapsed' class='d-none col-sm-12 enforce-bottom
       div.enforce-big-top-margin
         #turtlediv
           canvas#turtlecanvas.d-none width=400 height=400
-      div.enforce-big-top-margin
-        #hint
-          .card.bg-warning.text-white
-            .card-header = t('exercises.implement.hint')
-            .card-body
       div.enforce-big-top-margin
         #prompt.input-group.d-none
           div.input-group-prepend

app/views/hints/_form.html.slim

@@ -1,17 +0,0 @@
-= form_for(@hint, url: execution_environment_hints_path(params[:execution_environment_id])) do |f|
-  = render('shared/form_errors', object: @hint)
-  .form-group
-    = f.label(:name)
-    = f.text_field(:name, class: 'form-control', required: true)
-  .form-group
-    = f.label(:locale)
-    = f.select(:locale, I18n.available_locales.map { |locale| [t("locales.#{locale}"), locale] }, {}, class: 'form-control')
-  .form-group
-    = f.label(:message)
-    = f.text_field(:message, class: 'form-control', placeholder: "'$2' has no method '$1'.", required: true)
-    .help-block.form-text = t('.hints.message')
-  .form-group
-    = f.label(:regular_expression)
-    = f.text_field(:regular_expression, class: 'form-control', placeholder: 'undefined method (\w+) for (\w+)', required: true)
-    .help-block.form-text = t('.hints.regular_expression')
-  .actions = render('shared/submit_button', f: f, object: @hint)

app/views/hints/edit.html.slim

@@ -1,3 +0,0 @@
-h1 = @hint
-
-= render('form')

app/views/hints/index.html.slim

@@ -1,20 +0,0 @@
-h1 = Hint.model_name.human(count: 2)
-
-.table-responsive
-  table.table
-    thead
-      tr
-        th = t('activerecord.attributes.hint.name')
-        th = t('activerecord.attributes.hint.locale')
-        th colspan=3 = t('shared.actions')
-    tbody
-      - @hints.each do |hint|
-        tr
-          td = hint.name
-          td = t("locales.#{hint.locale}")
-          td = link_to(t('shared.show'), execution_environment_hint_path(params[:execution_environment_id], hint.id))
-          td = link_to(t('shared.edit'), edit_execution_environment_hint_path(params[:execution_environment_id], hint.id))
-          td = link_to(t('shared.destroy'), execution_environment_hint_path(params[:execution_environment_id], hint.id), data: {confirm: t('shared.confirm_destroy')}, method: :delete)
-
-= render('shared/pagination', collection: @hints)
-p = render('shared/new_button', model: Hint, path: new_execution_environment_hint_path(params[:execution_environment_id]))

app/views/hints/new.html.slim

@@ -1,3 +0,0 @@
-h1 = t('shared.new_model', model: Hint.model_name.human)
-
-= render('form')

app/views/hints/show.html.slim

@@ -1,8 +0,0 @@
-h1
-  = @hint
-  = render('shared/edit_button', object: @hint, path: edit_execution_environment_hint_path(params[:execution_environment_id], @hint.id))
-
-= row(label: 'hint.name', value: @hint.name)
-= row(label: 'hint.locale', value: t("locales.#{@hint.locale}"))
-= row(label: 'hint.message', value: @hint.message)
-= row(label: 'hint.regular_expression', value: code_tag(@hint.regular_expression))

app/views/tags/index.html.slim

@@ -5,8 +5,7 @@ h1 = Tag.model_name.human(count: 2)
     thead
       tr
         th = t('activerecord.attributes.hint.name')
-        /th = t('activerecord.attributes.hint.locale')
-        /th colspan=3 = t('shared.actions')
+        th colspan=3 = t('shared.actions')
     tbody
       - @tags.each do |tag|
         tr