htwkmooc/codeocean
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix tests and rename request variable in specs to perform_request

Browse Source 
Explanation: Using the variable name `request` might interfere with methods in Rails core system prevent successful test execution. See this issue: https://github.com/turbolinks/turbolinks-rails/issues/38
This commit is contained in:
Sebastian Serth
2018-10-08 09:53:04 +02:00
parent 9106ab182b
commit 90defa8f89
14 changed files with 80 additions and 79 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
spec/controllers/code_ocean/files_controller_spec.rb
View File

@ -8,13 +8,13 @@ describe CodeOcean::FilesController do
let(:submission) { FactoryBot.create(:submission, user: user) }
context 'with a valid file' do
let(:request) { proc { post :create, params: { code_ocean_file: FactoryBot.build(:file, context: submission).attributes, format: :json } } }
before(:each) { request.call }
let(:perform_request) { proc { post :create, params: { code_ocean_file: FactoryBot.build(:file, context: submission).attributes, format: :json } } }
before(:each) { perform_request.call }
expect_assigns(file: CodeOcean::File)
it 'creates the file' do
expect { request.call }.to change(CodeOcean::File, :count)
expect { perform_request.call }.to change(CodeOcean::File, :count)
end
expect_json
@ -32,14 +32,14 @@ describe CodeOcean::FilesController do
describe 'DELETE #destroy' do
let(:exercise) { FactoryBot.create(:fibonacci) }
let(:request) { proc { delete :destroy, params: { id: exercise.files.first.id } } }
before(:each) { request.call }
let(:perform_request) { proc { delete :destroy, params: { id: exercise.files.first.id } } }
before(:each) { perform_request.call }
expect_assigns(file: CodeOcean::File)
it 'destroys the file' do
FactoryBot.create(:fibonacci)
expect { request.call }.to change(CodeOcean::File, :count).by(-1)
expect { perform_request.call }.to change(CodeOcean::File, :count).by(-1)
end
expect_redirect(:exercise)