htwkmooc/codeocean
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix tests and rename request variable in specs to perform_request

Browse Source 
Explanation: Using the variable name `request` might interfere with methods in Rails core system prevent successful test execution. See this issue: https://github.com/turbolinks/turbolinks-rails/issues/38
This commit is contained in:
Sebastian Serth
2018-10-08 09:53:04 +02:00
parent 9106ab182b
commit 90defa8f89
14 changed files with 80 additions and 79 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
spec/controllers/hints_controller_spec.rb
View File

@ -8,14 +8,14 @@ describe HintsController do
describe 'POST #create' do
context 'with a valid hint' do
let(:request) { proc { post :create, params: { execution_environment_id: execution_environment.id, hint: FactoryBot.attributes_for(:ruby_syntax_error) } } }
before(:each) { request.call }
let(:perform_request) { proc { post :create, params: { execution_environment_id: execution_environment.id, hint: FactoryBot.attributes_for(:ruby_syntax_error) } } }
before(:each) { perform_request.call }
expect_assigns(execution_environment: :execution_environment)
expect_assigns(hint: Hint)
it 'creates the hint' do
expect { request.call }.to change(Hint, :count).by(1)
expect { perform_request.call }.to change(Hint, :count).by(1)
end
expect_redirect(Hint.last)