From 16a5345a710ba051c6f88deaec2b69b06f29d70c Mon Sep 17 00:00:00 2001
From: Sebastian Serth <Sebastian.Serth@student.hpi.de>
Date: Mon, 26 Nov 2018 12:23:30 +0100
Subject: [PATCH] Migrate jQuery function use for ajax in case of success or
 failure

Deprecation Notice:

The jqXHR.success(), jqXHR.error(), and jqXHR.complete() callbacks will be deprecated in jQuery 1.8. To prepare your code for their eventual removal, use jqXHR.done(), jqXHR.fail(), and jqXHR.always() instead.
---
 app/assets/javascripts/editor/editor.js.erb         | 2 +-
 app/assets/javascripts/editor/participantsupport.js | 2 +-
 app/assets/javascripts/editor/submissions.js        | 2 +-
 app/assets/javascripts/error_templates.js           | 4 ++--
 4 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/app/assets/javascripts/editor/editor.js.erb b/app/assets/javascripts/editor/editor.js.erb
index fe5a62b9..4e26723a 100644
--- a/app/assets/javascripts/editor/editor.js.erb
+++ b/app/assets/javascripts/editor/editor.js.erb
@@ -436,7 +436,7 @@ configureEditors: function () {
       url: $('#editor').data('errors-url')
     });
     jqxhr.always(this.hideSpinner);
-    jqxhr.success(this.renderHint);
+    jqxhr.done(this.renderHint);
   },
 
   toggleButtonStates: function () {
diff --git a/app/assets/javascripts/editor/participantsupport.js b/app/assets/javascripts/editor/participantsupport.js
index f0329256..479b09c9 100644
--- a/app/assets/javascripts/editor/participantsupport.js
+++ b/app/assets/javascripts/editor/participantsupport.js
@@ -83,7 +83,7 @@ CodeOceanEditorRequestForComments = {
         $.flash.success({text: $('#askForCommentsButton').data('message-success')});
         // trigger a run
         this.runSubmission.call(this, submission);
-      }.bind(this)).error(this.ajaxError.bind(this));
+      }.bind(this)).fail(this.ajaxError.bind(this));
     };
 
     this.createSubmission($('#requestComments'), null, createRequestForComments.bind(this));
diff --git a/app/assets/javascripts/editor/submissions.js b/app/assets/javascripts/editor/submissions.js
index 6c4fd96a..4dae40b5 100644
--- a/app/assets/javascripts/editor/submissions.js
+++ b/app/assets/javascripts/editor/submissions.js
@@ -106,7 +106,7 @@ CodeOceanEditorSubmissions = {
     this.ajax({
       method: 'GET',
       url: $('#start-over').data('url')
-    }).success(function(response) {
+    }).done(function(response) {
       this.hideSpinner();
       _.each(this.editors, function(editor) {
         var file_id = $(editor.container).data('file-id');
diff --git a/app/assets/javascripts/error_templates.js b/app/assets/javascripts/error_templates.js
index d01dbf0b..74978157 100644
--- a/app/assets/javascripts/error_templates.js
+++ b/app/assets/javascripts/error_templates.js
@@ -8,9 +8,9 @@ $(document).on('turbolinks:load', function() {
                     dataType: 'json',
                     error_template_attribute_id: $('#add-attribute').find('select').val()
                 }
-            }).success(function () {
+            }).done(function () {
                 location.reload();
-            }).error(function (error) {
+            }).fail(function (error) {
                 $.flash.danger({text: error.statusText});
             });
         });