Fix error, submission, hints and help views

app/controllers/application_controller.rb

@@ -14,9 +14,6 @@ class ApplicationController < ActionController::Base
     @current_user ||= ExternalUser.find_by(id: session[:external_user_id]) || login_from_session || login_from_other_sources
   end
 
-  def help
-  end
-
   def render_not_authorized
     redirect_to(:root, alert: t('application.not_authorized'))
   end

app/controllers/code_ocean/errors_controller.rb

@@ -0,0 +1,45 @@
+module CodeOcean
+  class ErrorsController < ApplicationController
+    before_action :set_execution_environment
+
+    def authorize!
+      authorize(@error || @errors)
+    end
+    private :authorize!
+
+    def create
+      @error = CodeOcean::Error.new(error_params)
+      authorize!
+      hint = Whistleblower.new(execution_environment: @error.execution_environment).generate_hint(@error.message)
+      respond_to do |format|
+        format.json do
+          if hint
+            render(json: {hint: hint})
+          else
+            head (@error.save ? :created : :unprocessable_entity)
+          end
+        end
+      end
+    end
+
+    def error_params
+      params[:error].permit(:message, :submission_id).merge(execution_environment_id: @execution_environment.id) if params[:error].present?
+    end
+    private :error_params
+
+    def index
+      @errors = CodeOcean::Error.for_execution_environment(@execution_environment).grouped_by_message.paginate(page: params[:page])
+      authorize!
+    end
+
+    def set_execution_environment
+      @execution_environment = ExecutionEnvironment.find(params[:execution_environment_id])
+    end
+    private :set_execution_environment
+
+    def show
+      @error = CodeOcean::Error.find(params[:id])
+      authorize!
+    end
+  end
+end

app/controllers/errors_controller.rb

@@ -1,43 +0,0 @@
-class ErrorsController < ApplicationController
-  before_action :set_execution_environment
-
-  def authorize!
-    authorize(@error || @errors)
-  end
-  private :authorize!
-
-  def create
-    @error = Error.new(error_params)
-    authorize!
-    hint = Whistleblower.new(execution_environment: @error.execution_environment).generate_hint(@error.message)
-    respond_to do |format|
-      format.json do
-        if hint
-          render(json: {hint: hint})
-        else
-          head (@error.save ? :created : :unprocessable_entity)
-        end
-      end
-    end
-  end
-
-  def error_params
-    params[:error].permit(:message, :submission_id).merge(execution_environment_id: @execution_environment.id) if params[:error].present?
-  end
-  private :error_params
-
-  def index
-    @errors = Error.for_execution_environment(@execution_environment).grouped_by_message.paginate(page: params[:page])
-    authorize!
-  end
-
-  def set_execution_environment
-    @execution_environment = ExecutionEnvironment.find(params[:execution_environment_id])
-  end
-  private :set_execution_environment
-
-  def show
-    @error = Error.find(params[:id])
-    authorize!
-  end
-end

app/controllers/submissions_controller.rb

@@ -366,7 +366,7 @@ class SubmissionsController < ApplicationController
   end
 
   def store_error(stderr)
-    ::Error.create(submission_id: @submission.id, execution_environment_id: @submission.execution_environment.id, message: stderr)
+    CodeOcean::Error.create(submission_id: @submission.id, execution_environment_id: @submission.execution_environment.id, message: stderr)
   end
   private :store_error