From 97138288f43ea8f7cbf91e041dcfc292836b5a4d Mon Sep 17 00:00:00 2001
From: kiragrammel <kira.grammel@student.hpi.de>
Date: Wed, 16 Aug 2023 00:16:21 +0200
Subject: [PATCH] Delete unused LTI params from session

---
 app/controllers/application_controller.rb     | 1 -
 app/controllers/concerns/lti.rb               | 2 --
 app/controllers/concerns/redirect_behavior.rb | 4 +---
 spec/concerns/lti_spec.rb                     | 3 ---
 4 files changed, 1 insertion(+), 9 deletions(-)

diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb
index 22f3b126..717972e3 100644
--- a/app/controllers/application_controller.rb
+++ b/app/controllers/application_controller.rb
@@ -67,7 +67,6 @@ class ApplicationController < ActionController::Base
 
       # All external users are logged in "manually"
       session[:external_user_id] = token.user.id
-      session.delete(:lti_parameters_id)
       token.user
     end
   end
diff --git a/app/controllers/concerns/lti.rb b/app/controllers/concerns/lti.rb
index 76ed55d6..0f71a280 100644
--- a/app/controllers/concerns/lti.rb
+++ b/app/controllers/concerns/lti.rb
@@ -110,7 +110,6 @@ module Lti
                 else
                   proxy_exercise.get_matching_exercise(current_user)
                 end
-    session[:lti_exercise_id] = @exercise.id if @exercise
     refuse_lti_launch(message: t('sessions.oauth.invalid_exercise_token')) unless @exercise
   end
 
@@ -242,7 +241,6 @@ module Lti
     @lti_parameters = lti_parameters
 
     session[:external_user_id] = current_user.id
-    session[:lti_parameters_id] = lti_parameters.id
   end
 
   private :store_lti_session_data
diff --git a/app/controllers/concerns/redirect_behavior.rb b/app/controllers/concerns/redirect_behavior.rb
index 6ef92fa6..aca1308d 100644
--- a/app/controllers/concerns/redirect_behavior.rb
+++ b/app/controllers/concerns/redirect_behavior.rb
@@ -124,9 +124,7 @@ module RedirectBehavior
       session: session.to_hash,
       submission: @submission.inspect,
       params: params.as_json,
-      current_user:,
-      lti_exercise_id: session[:lti_exercise_id],
-      lti_parameters_id: session[:lti_parameters_id]
+      current_user:
     )
 
     path = lti_return_path(submission_id: @submission.id)
diff --git a/spec/concerns/lti_spec.rb b/spec/concerns/lti_spec.rb
index e8ea620c..820b1ee8 100644
--- a/spec/concerns/lti_spec.rb
+++ b/spec/concerns/lti_spec.rb
@@ -22,8 +22,6 @@ describe Lti do
       expect(controller.session).to receive(:delete).with(:external_user_id)
       expect(controller.session).to receive(:delete).with(:study_group_id)
       expect(controller.session).to receive(:delete).with(:embed_options)
-      expect(controller.session).to receive(:delete).with(:lti_exercise_id)
-      expect(controller.session).to receive(:delete).with(:lti_parameters_id)
       controller.send(:clear_lti_session_data)
     end
   end
@@ -174,7 +172,6 @@ describe Lti do
       controller.instance_variable_set(:@current_user, create(:external_user))
       controller.instance_variable_set(:@exercise, create(:fibonacci))
       expect(controller.session).to receive(:[]=).with(:external_user_id, anything)
-      expect(controller.session).to receive(:[]=).with(:lti_parameters_id, anything)
       controller.send(:store_lti_session_data, consumer: build(:consumer), parameters:)
     end