htwkmooc/codeocean
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Check polymorphic type in validations

Browse Source 
* Previously, some models had "duplicated" `belongs_to` associations, which were now removed (and replaced by the `include Creation`).
This commit is contained in:
Sebastian Serth
2023-08-20 18:01:18 +02:00
committed by Sebastian Serth
parent be4f2b790d
commit 977fa4539e
16 changed files with 26 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/models/code_ocean/file.rb
View File

@ -12,6 +12,7 @@ module CodeOcean
TEACHER_DEFINED_ROLES = ROLES - %w[user_defined_file]
OWNER_READ_PERMISSION = 0o400
OTHER_READ_PERMISSION = 0o004
ALLOWED_CONTEXT_TYPES = %w[Exercise Submission CommunitySolution CommunitySolutionContribution].freeze
after_initialize :set_default_values
before_validation :clear_weight, unless: :teacher_defined_assessment?
@ -56,6 +57,7 @@ module CodeOcean
validates :weight, if: :teacher_defined_assessment?, numericality: true, presence: true
validates :weight, absence: true, unless: :teacher_defined_assessment?
validates :file, presence: true if :context.is_a?(Submission)
validates :context_type, inclusion: {in: ALLOWED_CONTEXT_TYPES}
validates_with FileNameValidator, fields: %i[name path file_type_id]