Lint Slim files and fix offenses

The fixing was partially done manually and partially automatically.
This commit is contained in:
Sebastian Serth
2024-04-13 20:06:03 +02:00
committed by Dominic Sauer
parent ddfa06ffaa
commit 9a9efd5caa
91 changed files with 378 additions and 392 deletions

View File

@@ -15,10 +15,10 @@ h1 = ExternalUser.model_name.human(count: 2)
= f.search_field(:external_id_cont, class: 'form-control', placeholder: t('activerecord.attributes.external_user.external_id'))
.row
.col-auto
= f.select :platform_admin_true, [[t('shared.admin_filter.only'), 1], [t('shared.admin_filter.none'), 0]], { include_blank: t('shared.admin_filter.all'), selected: params[:q] ? params[:q][:platform_admin_true] : '' }
= f.select :platform_admin_true, [[t('shared.admin_filter.only'), 1], [t('shared.admin_filter.none'), 0]], {include_blank: t('shared.admin_filter.all'), selected: params[:q] ? params[:q][:platform_admin_true] : ''}
.col-auto.mt-3.mt-lg-0
= f.label(:consumer_id_eq, t('activerecord.attributes.external_user.consumer'), class: 'visually-hidden form-label')
= f.collection_select(:consumer_id_eq, Consumer.with_external_users, :id, :name, class: 'form-control', include_blank: true, prompt: t('activerecord.attributes.external_user.consumer') )
= f.collection_select(:consumer_id_eq, Consumer.with_external_users, :id, :name, class: 'form-control', include_blank: true, prompt: t('activerecord.attributes.external_user.consumer'))
- else
.col-auto
= f.label(:name_cont, t('activerecord.attributes.external_user.name'), class: 'visually-hidden form-label')

View File

@@ -8,10 +8,10 @@ h1 = @user.displayname
= row(label: 'external_user.consumer', value: link_to_if(@user.consumer.present? && policy(@user.consumer).show?, @user.consumer, @user.consumer))
= row(label: 'external_user.platform_admin', value: @user.platform_admin?) if current_user.admin?
= row(label: 'users.show.study_groups') do
- visible_memberships = @user.study_group_memberships.select { |study_group_membership| policy(study_group_membership.study_group).show? }
- visible_memberships = @user.study_group_memberships.select {|study_group_membership| policy(study_group_membership.study_group).show? }
- if visible_memberships.any?
ul.mb-0 class="#{visible_memberships.one? ? 'single_entry_inline_list' : 'inline_list'}"
- visible_memberships = visible_memberships.sort_by{ |study_group_membership| study_group_membership.study_group.name}
ul.mb-0 class=(visible_memberships.one? ? 'single_entry_inline_list' : 'inline_list')
- visible_memberships = visible_memberships.sort_by {|study_group_membership| study_group_membership.study_group.name }
- visible_memberships.each do |study_group_membership|
li
=> link_to(study_group_membership.study_group.name, study_group_membership.study_group)

View File

@@ -1,13 +1,13 @@
h1 = t('.title')
- submissions = Submission.where(contributor: @user).in_study_group_of(current_user)
- exercises = Exercise.where(id: submissions.joins(:exercise).group(:exercise_id).select(:exercise_id).distinct).reject(&:nil?)
- exercises = Exercise.where(id: submissions.joins(:exercise).group(:exercise_id).select(:exercise_id).distinct).compact
- if submissions.any? && !policy(exercises.first).detailed_statistics?
- submissions = submissions.final
- if submissions.any?
.table-responsive
table.table.table-striped class="#{exercises.present? ? 'sortable' : ''}"
table.table.table-striped class=(exercises.present? ? 'sortable' : '')
thead
tr
th.header = t('.exercise')
@@ -18,14 +18,14 @@ h1 = t('.title')
tbody
- exercises.each do |exercise|
// Grab any submission in context of study group (or all if admin). Then check for permission
- any_submission = submissions.where(exercise: exercise).first
- any_submission = submissions.where(exercise:).first
- if any_submission && policy(any_submission).show_study_group? && statistics[exercise.id]
- stats = statistics[exercise.id]
tr
td = link_to exercise, controller: "exercises", action: "external_user_statistics", external_user_id: @user.id, id: exercise.id
td = stats["maximum_score"] or 0
td = link_to exercise, controller: 'exercises', action: 'external_user_statistics', external_user_id: @user.id, id: exercise.id
td = stats['maximum_score'] || 0
td.align-middle
- latest_viewable_submission = submissions.where(exercise: exercise).final.latest
- latest_viewable_submission = submissions.where(exercise:).final.latest
- if latest_viewable_submission.present?
- if latest_viewable_submission.before_deadline?
.unit-test-result.positive-result.before_deadline
@@ -33,7 +33,7 @@ h1 = t('.title')
.unit-test-result.unknown-result.within_grace_period
- elsif latest_viewable_submission.after_late_deadline?
.unit-test-result.negative-result.after_late_deadline
td = stats["runs"] or 0 if policy(exercises.first).detailed_statistics?
td = stats["working_time"] or 0 if policy(exercises.first).detailed_statistics?
td = stats['runs'] || 0 if policy(exercises.first).detailed_statistics?
td = stats['working_time'] || 0 if policy(exercises.first).detailed_statistics?
- else
= t('exercises.external_users.statistics.no_data_available')