htwkmooc/codeocean
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fallback to default height if editor offset cannot be determined

Browse Source 
Fixes CODEOCEAN-B6, Fixes CODEOCEAN-E1, Fixes CODEOCEAN-BZ
This commit is contained in:
Sebastian Serth
2022-10-06 00:24:23 +02:00
parent df384ebf0d
commit 9e1f2da02e
1 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
app/assets/javascripts/editor/editor.js.erb
View File

@ -231,9 +231,14 @@ var CodeOceanEditor = {
}, },
calculateEditorHeight: function (element, considerStatusbar) { calculateEditorHeight: function (element, considerStatusbar) {
let bottom = considerStatusbar ? ($('#statusbar').height() || 0) : 0; const jqueryElement = $(element);
if (jqueryElement.length === 0) {
return 0;
}
const bottom = considerStatusbar ? ($('#statusbar').height() || 0) : 0;
// calculate needed size: window height - position of top of ACE editor - height of autosave label below editor - 5 for bar margins // calculate needed size: window height - position of top of ACE editor - height of autosave label below editor - 5 for bar margins
return window.innerHeight - $(element).offset().top - bottom - 5; return window.innerHeight - jqueryElement.offset().top - bottom - 5;
}, },
resizeParentOfAceEditor: function (element) { resizeParentOfAceEditor: function (element) {