From a4e791e3de6cdf945beb45f86fb9fc60c3b20900 Mon Sep 17 00:00:00 2001 From: Sebastian Serth Date: Wed, 2 Nov 2022 12:25:33 +0100 Subject: [PATCH] Always render templates in Controller specs --- spec/controllers/admin/dashboard_controller_spec.rb | 2 ++ spec/controllers/application_controller_spec.rb | 2 ++ spec/controllers/code_ocean/files_controller_spec.rb | 2 ++ spec/controllers/codeharbor_links_controller_spec.rb | 2 ++ spec/controllers/comments_controller_spec.rb | 2 ++ spec/controllers/consumers_controller_spec.rb | 2 ++ spec/controllers/error_template_attributes_controller_spec.rb | 2 ++ spec/controllers/error_templates_controller_spec.rb | 2 ++ spec/controllers/events_controller_spec.rb | 2 ++ spec/controllers/execution_environments_controller_spec.rb | 2 ++ spec/controllers/exercises_controller_spec.rb | 2 ++ spec/controllers/external_users_controller_spec.rb | 2 ++ spec/controllers/file_types_controller_spec.rb | 2 ++ spec/controllers/internal_users_controller_spec.rb | 2 ++ spec/controllers/ping_controller_spec.rb | 2 ++ spec/controllers/request_for_comments_controller_spec.rb | 2 ++ spec/controllers/sessions_controller_spec.rb | 2 ++ spec/controllers/statistics_controller_spec.rb | 2 ++ spec/controllers/submissions_controller_spec.rb | 2 ++ 19 files changed, 38 insertions(+) diff --git a/spec/controllers/admin/dashboard_controller_spec.rb b/spec/controllers/admin/dashboard_controller_spec.rb index e0c581b2..5a0003fa 100644 --- a/spec/controllers/admin/dashboard_controller_spec.rb +++ b/spec/controllers/admin/dashboard_controller_spec.rb @@ -3,6 +3,8 @@ require 'rails_helper' describe Admin::DashboardController do + render_views + before { allow(controller).to receive(:current_user).and_return(build(:admin)) } describe 'GET #show' do diff --git a/spec/controllers/application_controller_spec.rb b/spec/controllers/application_controller_spec.rb index 03c6cb85..cba3cd96 100644 --- a/spec/controllers/application_controller_spec.rb +++ b/spec/controllers/application_controller_spec.rb @@ -3,6 +3,8 @@ require 'rails_helper' describe ApplicationController do + render_views + describe '#current_user' do context 'with an external user' do let(:external_user) { create(:external_user) } diff --git a/spec/controllers/code_ocean/files_controller_spec.rb b/spec/controllers/code_ocean/files_controller_spec.rb index 41f042d9..3209f87a 100644 --- a/spec/controllers/code_ocean/files_controller_spec.rb +++ b/spec/controllers/code_ocean/files_controller_spec.rb @@ -3,6 +3,8 @@ require 'rails_helper' describe CodeOcean::FilesController do + render_views + let(:user) { create(:admin) } before { allow(controller).to receive(:current_user).and_return(user) } diff --git a/spec/controllers/codeharbor_links_controller_spec.rb b/spec/controllers/codeharbor_links_controller_spec.rb index 752d9811..7eb99c87 100644 --- a/spec/controllers/codeharbor_links_controller_spec.rb +++ b/spec/controllers/codeharbor_links_controller_spec.rb @@ -3,6 +3,8 @@ require 'rails_helper' describe CodeharborLinksController do + render_views + let(:user) { create(:teacher) } before do diff --git a/spec/controllers/comments_controller_spec.rb b/spec/controllers/comments_controller_spec.rb index 3511a538..d0374023 100644 --- a/spec/controllers/comments_controller_spec.rb +++ b/spec/controllers/comments_controller_spec.rb @@ -3,6 +3,8 @@ require 'rails_helper' describe CommentsController do + render_views + let(:user) { create(:learner) } let(:rfc_with_comment) { create(:rfc_with_comment, user: user) } let(:comment) { rfc_with_comment.comments.first } diff --git a/spec/controllers/consumers_controller_spec.rb b/spec/controllers/consumers_controller_spec.rb index 85d87b15..74e1d6b8 100644 --- a/spec/controllers/consumers_controller_spec.rb +++ b/spec/controllers/consumers_controller_spec.rb @@ -3,6 +3,8 @@ require 'rails_helper' describe ConsumersController do + render_views + let(:consumer) { create(:consumer) } let(:user) { create(:admin) } diff --git a/spec/controllers/error_template_attributes_controller_spec.rb b/spec/controllers/error_template_attributes_controller_spec.rb index e3e28f44..ff4d400d 100644 --- a/spec/controllers/error_template_attributes_controller_spec.rb +++ b/spec/controllers/error_template_attributes_controller_spec.rb @@ -3,6 +3,8 @@ require 'rails_helper' describe ErrorTemplateAttributesController do + render_views + let!(:error_template_attribute) { create(:error_template_attribute) } let(:user) { create(:admin) } diff --git a/spec/controllers/error_templates_controller_spec.rb b/spec/controllers/error_templates_controller_spec.rb index 830cf68f..024684ef 100644 --- a/spec/controllers/error_templates_controller_spec.rb +++ b/spec/controllers/error_templates_controller_spec.rb @@ -3,6 +3,8 @@ require 'rails_helper' describe ErrorTemplatesController do + render_views + let!(:error_template) { create(:error_template) } let(:user) { create(:admin) } diff --git a/spec/controllers/events_controller_spec.rb b/spec/controllers/events_controller_spec.rb index 888d9280..de549505 100644 --- a/spec/controllers/events_controller_spec.rb +++ b/spec/controllers/events_controller_spec.rb @@ -3,6 +3,8 @@ require 'rails_helper' describe EventsController do + render_views + let(:user) { create(:admin) } let(:exercise) { create(:fibonacci) } diff --git a/spec/controllers/execution_environments_controller_spec.rb b/spec/controllers/execution_environments_controller_spec.rb index aee51f6d..065f6e54 100644 --- a/spec/controllers/execution_environments_controller_spec.rb +++ b/spec/controllers/execution_environments_controller_spec.rb @@ -3,6 +3,8 @@ require 'rails_helper' describe ExecutionEnvironmentsController do + render_views + let(:execution_environment) { create(:ruby) } let(:user) { create(:admin) } diff --git a/spec/controllers/exercises_controller_spec.rb b/spec/controllers/exercises_controller_spec.rb index b6c38477..5ed4c2d8 100644 --- a/spec/controllers/exercises_controller_spec.rb +++ b/spec/controllers/exercises_controller_spec.rb @@ -3,6 +3,8 @@ require 'rails_helper' describe ExercisesController do + render_views + let(:exercise) { create(:dummy) } let(:user) { create(:admin) } diff --git a/spec/controllers/external_users_controller_spec.rb b/spec/controllers/external_users_controller_spec.rb index 4530c78a..b2c1a385 100644 --- a/spec/controllers/external_users_controller_spec.rb +++ b/spec/controllers/external_users_controller_spec.rb @@ -3,6 +3,8 @@ require 'rails_helper' describe ExternalUsersController do + render_views + let(:user) { build(:admin) } let!(:users) { create_pair(:external_user) } diff --git a/spec/controllers/file_types_controller_spec.rb b/spec/controllers/file_types_controller_spec.rb index 45f327b7..2de7c8e2 100644 --- a/spec/controllers/file_types_controller_spec.rb +++ b/spec/controllers/file_types_controller_spec.rb @@ -3,6 +3,8 @@ require 'rails_helper' describe FileTypesController do + render_views + let(:file_type) { create(:dot_rb) } let(:user) { create(:admin) } diff --git a/spec/controllers/internal_users_controller_spec.rb b/spec/controllers/internal_users_controller_spec.rb index 70b3f051..4dc32be9 100644 --- a/spec/controllers/internal_users_controller_spec.rb +++ b/spec/controllers/internal_users_controller_spec.rb @@ -3,6 +3,8 @@ require 'rails_helper' describe InternalUsersController do + render_views + let(:user) { create(:admin) } describe 'GET #activate' do diff --git a/spec/controllers/ping_controller_spec.rb b/spec/controllers/ping_controller_spec.rb index 74b79822..0ffb7fb4 100644 --- a/spec/controllers/ping_controller_spec.rb +++ b/spec/controllers/ping_controller_spec.rb @@ -3,6 +3,8 @@ require 'rails_helper' RSpec.describe PingController do + render_views + describe 'index' do it 'returns the wanted page and answer with HTTP Status 200' do get :index diff --git a/spec/controllers/request_for_comments_controller_spec.rb b/spec/controllers/request_for_comments_controller_spec.rb index f607fac2..49fe73e6 100644 --- a/spec/controllers/request_for_comments_controller_spec.rb +++ b/spec/controllers/request_for_comments_controller_spec.rb @@ -3,6 +3,8 @@ require 'rails_helper' describe RequestForCommentsController do + render_views + let(:user) { create(:admin) } before { allow(controller).to receive(:current_user).and_return(user) } diff --git a/spec/controllers/sessions_controller_spec.rb b/spec/controllers/sessions_controller_spec.rb index 0e026c5b..0375e035 100644 --- a/spec/controllers/sessions_controller_spec.rb +++ b/spec/controllers/sessions_controller_spec.rb @@ -3,6 +3,8 @@ require 'rails_helper' describe SessionsController do + render_views + let(:consumer) { create(:consumer) } describe 'POST #create' do diff --git a/spec/controllers/statistics_controller_spec.rb b/spec/controllers/statistics_controller_spec.rb index 78d367e6..c8c5fa15 100644 --- a/spec/controllers/statistics_controller_spec.rb +++ b/spec/controllers/statistics_controller_spec.rb @@ -3,6 +3,8 @@ require 'rails_helper' describe StatisticsController do + render_views + let(:user) { create(:admin) } before { allow(controller).to receive(:current_user).and_return(user) } diff --git a/spec/controllers/submissions_controller_spec.rb b/spec/controllers/submissions_controller_spec.rb index ed33a37f..beb24fef 100644 --- a/spec/controllers/submissions_controller_spec.rb +++ b/spec/controllers/submissions_controller_spec.rb @@ -3,6 +3,8 @@ require 'rails_helper' describe SubmissionsController do + render_views + let(:submission) { create(:submission) } let(:user) { create(:admin) }