htwkmooc/codeocean
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove outdated HTTP status codes

Browse Source 
See https://github.com/openHPI/codeocean/pull/1349#pullrequestreview-1091652523
This commit is contained in:
Sebastian Serth
2022-08-31 13:50:07 +02:00
committed by Sebastian Serth
parent ba821bd18b
commit a5da7d1f84
2 changed files with 0 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
lib/runner/strategy/poseidon.rb
View File

@ -34,8 +34,6 @@ class Runner::Strategy::Poseidon < Runner::Strategy
else else
execution_environments execution_environments
end end
when 404
raise Runner::Error::EnvironmentNotFound.new
else else
handle_error response handle_error response
end end
@ -258,9 +256,6 @@ class Runner::Strategy::Poseidon < Runner::Strategy
response_body = self.class.parse response response_body = self.class.parse response
websocket_url = response_body[:websocketUrl] websocket_url = response_body[:websocketUrl]
websocket_url.presence || raise(Runner::Error::UnexpectedResponse.new('Poseidon did not send a WebSocket URL')) websocket_url.presence || raise(Runner::Error::UnexpectedResponse.new('Poseidon did not send a WebSocket URL'))
when 400
Runner.destroy(@allocation_id)
self.class.handle_error response
else else
self.class.handle_error response self.class.handle_error response
end end

1
spec/lib/runner/strategy/poseidon_spec.rb
View File

@ -291,7 +291,6 @@ describe Runner::Strategy::Poseidon do
end end
include_examples 'BadRequest (400) error handling' include_examples 'BadRequest (400) error handling'
include_examples 'BadRequest (400) destroys local runner'
include_examples 'Unauthorized (401) error handling' include_examples 'Unauthorized (401) error handling'
include_examples 'Gone (410) error handling' include_examples 'Gone (410) error handling'
include_examples 'InternalServerError (500) error handling' include_examples 'InternalServerError (500) error handling'