htwkmooc/codeocean
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix display of submitted score for remoteSubmit

Browse Source
This commit is contained in:
Sebastian Serth
2020-11-27 19:09:45 +01:00
parent aac0e69282
commit a7869ff401
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
app/controllers/remote_evaluation_controller.rb
View File

@ -25,13 +25,14 @@ class RemoteEvaluationController < ApplicationController
if @submission.present? if @submission.present?
current_user = @submission.user current_user = @submission.user
score_achieved_percentage = @submission.normalized_score * 100 score_achieved_percentage = @submission.normalized_score
if !current_user.nil? && lti_outcome_service?(@submission.exercise_id, current_user.id) if !current_user.nil? && lti_outcome_service?(@submission.exercise_id, current_user.id)
lti_response = send_score(@submission) lti_response = send_score(@submission)
if lti_response[:status] == 'success' and lti_response[:score_sent] != @submission.normalized_score if lti_response[:status] == 'success' and lti_response[:score_sent] != @submission.normalized_score
# Score has been reduced due to the passed deadline # Score has been reduced due to the passed deadline
result = {message: I18n.t('exercises.submit.too_late'), status: 207} result = {message: I18n.t('exercises.submit.too_late'), status: 207}
score_achieved_percentage = lti_response[:score_sent]
elsif lti_response[:status] == 'success' elsif lti_response[:status] == 'success'
result = {message: I18n.t('sessions.destroy_through_lti.success_with_outcome', consumer: @submission.user.consumer.name), status: 202} result = {message: I18n.t('sessions.destroy_through_lti.success_with_outcome', consumer: @submission.user.consumer.name), status: 202}
else else
@ -42,7 +43,7 @@ class RemoteEvaluationController < ApplicationController
result = {message: "Your submission was successfully scored with #{score_achieved_percentage}%. However, your score could not be sent to the e-Learning platform. Please reopen the exercise through the e-Learning platform and try again.", status: 410} result = {message: "Your submission was successfully scored with #{score_achieved_percentage}%. However, your score could not be sent to the e-Learning platform. Please reopen the exercise through the e-Learning platform and try again.", status: 410}
end end
result.merge!({score: score_achieved_percentage}) result.merge!({score: score_achieved_percentage * 100})
status = result[:status] status = result[:status]
end end