Reduce SQL queries in the exercise controller

Fixes CODEOCEAN-JK
2023-03-14 20:58:21 +01:00
parent d410c67473
commit a7cd85507e
4 changed files with 10 additions and 6 deletions
--- a/app/models/exercise.rb
+++ b/app/models/exercise.rb
@ -517,7 +517,11 @@ class Exercise < ApplicationRecord
        0
      end
    else
-      @maximum_score ||= files.teacher_defined_assessments.sum(:weight)
+      @maximum_score ||= if files.loaded?
+                           files.filter(&:teacher_defined_assessment?).pluck(:weight).sum
+                         else
+                           files.teacher_defined_assessments.sum(:weight)
+                         end
    end
  end