diff --git a/app/controllers/exercises_controller.rb b/app/controllers/exercises_controller.rb index 81e1fb34..ec9f8985 100644 --- a/app/controllers/exercises_controller.rb +++ b/app/controllers/exercises_controller.rb @@ -617,7 +617,7 @@ class ExercisesController < ApplicationController end else # redirect to feedback page if score is less than 100 percent - if @exercise.needs_more_feedback? && !@embed_options[:disable_redirect_to_feedback] + if @exercise.needs_more_feedback?(@submission) && !@embed_options[:disable_redirect_to_feedback] clear_lti_session_data(@submission.exercise_id, @submission.user_id, session[:consumer_id]) redirect_to_user_feedback else diff --git a/app/controllers/user_exercise_feedbacks_controller.rb b/app/controllers/user_exercise_feedbacks_controller.rb index a001b65e..1d8293c5 100644 --- a/app/controllers/user_exercise_feedbacks_controller.rb +++ b/app/controllers/user_exercise_feedbacks_controller.rb @@ -97,7 +97,26 @@ class UserExerciseFeedbacksController < ApplicationController end def uef_params - params[:user_exercise_feedback].permit(:feedback_text, :difficulty, :exercise_id, :user_estimated_worktime).merge(user_id: current_user.id, user_type: current_user.class.name) if params[:user_exercise_feedback].present? + return unless params[:user_exercise_feedback].present? + + exercise_id = if params[:user_exercise_feedback].nil? + params[:exercise_id] + else + params[:user_exercise_feedback][:exercise_id] + end + + user_id = current_user.id + user_type = current_user.class.name + latest_submission = Submission + .where(user_id: user_id, user_type: user_type, exercise_id: exercise_id) + .order(created_at: :desc).first + + params[:user_exercise_feedback] + .permit(:feedback_text, :difficulty, :exercise_id, :user_estimated_worktime) + .merge(user_id: user_id, + user_type: user_type, + submission: latest_submission, + normalized_score: latest_submission.normalized_score) end def validate_inputs(uef_params) diff --git a/app/models/exercise.rb b/app/models/exercise.rb index 07eae2c9..7ee3fb73 100644 --- a/app/models/exercise.rb +++ b/app/models/exercise.rb @@ -46,7 +46,7 @@ class Exercise < ApplicationRecord @working_time_statistics = nil attr_reader :working_time_statistics - MAX_EXERCISE_FEEDBACKS = 20 + MAX_GROUP_EXERCISE_FEEDBACKS = 20 def average_percentage if average_score && (maximum_score != 0.0) && submissions.exists?(cause: 'submit') @@ -550,8 +550,12 @@ class Exercise < ApplicationRecord end private :valid_submission_deadlines? - def needs_more_feedback? - user_exercise_feedbacks.size <= MAX_EXERCISE_FEEDBACKS + def needs_more_feedback?(submission) + if submission.normalized_score == 1.00 + user_exercise_feedbacks.final.size <= MAX_GROUP_EXERCISE_FEEDBACKS + else + user_exercise_feedbacks.intermediate.size <= MAX_GROUP_EXERCISE_FEEDBACKS + end end def last_submission_per_user diff --git a/app/models/submission.rb b/app/models/submission.rb index bbd3c735..62d7ad8e 100644 --- a/app/models/submission.rb +++ b/app/models/submission.rb @@ -101,9 +101,9 @@ class Submission < ApplicationRecord end def redirect_to_feedback? - # Redirect 10% of users to the exercise feedback page. Ensure, that always the - # same users get redirected per exercise and different users for different exercises. - # If desired, the number of feedbacks can be limited with exercise.needs_more_feedback? + # Redirect 10% of users to the exercise feedback page. Ensure, that always the same + # users get redirected per exercise and different users for different exercises. If + # desired, the number of feedbacks can be limited with exercise.needs_more_feedback?(submission) (user_id + exercise.created_at.to_i) % 10 == 1 end diff --git a/app/models/user_exercise_feedback.rb b/app/models/user_exercise_feedback.rb index 8d7b697f..f236f0c0 100644 --- a/app/models/user_exercise_feedback.rb +++ b/app/models/user_exercise_feedback.rb @@ -2,10 +2,14 @@ class UserExerciseFeedback < ApplicationRecord include Creation belongs_to :exercise + belongs_to :submission, optional: true has_one :execution_environment, through: :exercise validates :user_id, uniqueness: { scope: [:exercise_id, :user_type] } + scope :intermediate, -> { where.not(normalized_score: 1.00) } + scope :final, -> { where(normalized_score: 1.00) } + def to_s "User Exercise Feedback" end diff --git a/db/migrate/20201019090123_add_normalized_score_and_submission_to_user_exercise_feedback.rb b/db/migrate/20201019090123_add_normalized_score_and_submission_to_user_exercise_feedback.rb new file mode 100644 index 00000000..cfa13bb0 --- /dev/null +++ b/db/migrate/20201019090123_add_normalized_score_and_submission_to_user_exercise_feedback.rb @@ -0,0 +1,23 @@ +class AddNormalizedScoreAndSubmissionToUserExerciseFeedback < ActiveRecord::Migration[5.2] + def change + add_column :user_exercise_feedbacks, :normalized_score, :float + add_reference :user_exercise_feedbacks, :submission, foreign_key: true + + # Disable automatic timestamp modification + ActiveRecord::Base.record_timestamps = false + UserExerciseFeedback.all.find_each do |uef| + latest_submission = Submission + .where(user_id: uef.user_id, user_type: uef.user_type, exercise_id: uef.exercise_id) + .where('created_at < ?', uef.updated_at) + .order(created_at: :desc).first + + # In the beginning, CodeOcean allowed feedback for exercises while viewing an RfC. As a RfC + # might be opened by any registered learner, feedback for exercises was created by learners + # without having any submission for this particular exercise. + next if latest_submission.nil? + + uef.update(submission: latest_submission, normalized_score: latest_submission.normalized_score) + end + ActiveRecord::Base.record_timestamps = true + end +end diff --git a/db/schema.rb b/db/schema.rb index d39c8898..112687e7 100644 --- a/db/schema.rb +++ b/db/schema.rb @@ -10,7 +10,7 @@ # # It's strongly recommended that you check this file into your version control system. -ActiveRecord::Schema.define(version: 2020_10_07_104221) do +ActiveRecord::Schema.define(version: 2020_10_19_090123) do # These are extensions that must be enabled in order to support this database enable_extension "plpgsql" @@ -423,6 +423,9 @@ ActiveRecord::Schema.define(version: 2020_10_07_104221) do t.integer "user_estimated_worktime" t.datetime "created_at", null: false t.datetime "updated_at", null: false + t.float "normalized_score" + t.bigint "submission_id" + t.index ["submission_id"], name: "index_user_exercise_feedbacks_on_submission_id" end create_table "user_exercise_interventions", id: :serial, force: :cascade do |t| @@ -455,4 +458,5 @@ ActiveRecord::Schema.define(version: 2020_10_07_104221) do add_foreign_key "request_for_comments", "submissions", name: "request_for_comments_submissions_id_fk" add_foreign_key "submissions", "study_groups" add_foreign_key "tips", "file_types" + add_foreign_key "user_exercise_feedbacks", "submissions" end