From 7505d8c85e31af279d9ef3fdebb73b0a574c237c Mon Sep 17 00:00:00 2001
From: Maximilian Grundke <maximiliangrundke@googlemail.com>
Date: Tue, 10 Apr 2018 15:27:50 +0200
Subject: [PATCH 1/3] Parse run output of implicit RFC testrun and display it
 instead of raw socket messages

---
 app/views/request_for_comments/show.html.erb | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/app/views/request_for_comments/show.html.erb b/app/views/request_for_comments/show.html.erb
index d3751d0b..bfc117fa 100644
--- a/app/views/request_for_comments/show.html.erb
+++ b/app/views/request_for_comments/show.html.erb
@@ -46,7 +46,17 @@
           <div class="testrun-output text">
             <span class="fa fa-chevron-up collapse-button"></span>
             <% output_runs.each do |testrun| %>
-              <pre><%= testrun.try(:output) or t('request_for_comments.no_output') %></pre>
+              <%
+                output = testrun.try(:output)
+                if output
+                  messages = output.scan(/{(?:(?:".+?":".+?")+?,?)+}/)
+                  messages.map! {|el| JSON.parse(el)}
+                  messages.keep_if {|message| message['cmd'] == 'write'}
+                  messages.map! {|message| message['data']}
+                  output = messages.join ''
+                end
+              %>
+              <pre><%= output or t('request_for_comments.no_output') %></pre>
             <% end %>
           </div>
         <% end %>

From fc614ce4acc96c808987ae7ebf12e765b8e12d1b Mon Sep 17 00:00:00 2001
From: Maximilian Grundke <maximiliangrundke@googlemail.com>
Date: Tue, 10 Apr 2018 15:31:23 +0200
Subject: [PATCH 2/3] Hide run output by default

---
 app/views/request_for_comments/show.html.erb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/app/views/request_for_comments/show.html.erb b/app/views/request_for_comments/show.html.erb
index bfc117fa..e4e83147 100644
--- a/app/views/request_for_comments/show.html.erb
+++ b/app/views/request_for_comments/show.html.erb
@@ -43,8 +43,8 @@
         <% output_runs = testruns.select { |run| run.cause == 'run' } %>
         <% if output_runs.size > 0 %>
           <h5><%= t('request_for_comments.runtime_output') %></h5>
-          <div class="testrun-output text">
-            <span class="fa fa-chevron-up collapse-button"></span>
+          <div class="collapsed testrun-output text">
+            <span class="fa fa-chevron-down collapse-button"></span>
             <% output_runs.each do |testrun| %>
               <%
                 output = testrun.try(:output)

From 6898571dffeb0b026650f435d1df711123284ef2 Mon Sep 17 00:00:00 2001
From: Maximilian Grundke <maximiliangrundke@googlemail.com>
Date: Tue, 10 Apr 2018 16:02:53 +0200
Subject: [PATCH 3/3] Explicitly show unit test results

---
 .../stylesheets/request-for-comments.css.scss | 104 ++++++++++--------
 app/views/request_for_comments/show.html.erb  |   8 +-
 2 files changed, 63 insertions(+), 49 deletions(-)

diff --git a/app/assets/stylesheets/request-for-comments.css.scss b/app/assets/stylesheets/request-for-comments.css.scss
index 2cad6446..bf7f0cb4 100644
--- a/app/assets/stylesheets/request-for-comments.css.scss
+++ b/app/assets/stylesheets/request-for-comments.css.scss
@@ -53,64 +53,72 @@
     }
   }
 
-}
+  .testrun-assess-results {
 
-.testrun-assess-results {
+    .testrun-container {
+      display: flex;
+      margin-bottom: 10px;
 
-  display: flex;
+      .testrun-output {
+        overflow-x: auto;
+        flex-grow: 1;
+      }
+    }
+
+    .result {
+      margin-right: 10px;
+      margin-top: 20px;
+      width: 10px;
+      height: 10px;
+    }
+
+    .passed {
+      border-radius: 50%;
+      background-color: #8efa00;
+      -webkit-box-shadow: 0 0 11px 1px rgba(44,222,0,1);
+      -moz-box-shadow: 0 0 11px 1px rgba(44,222,0,1);
+      box-shadow: 0 0 11px 1px rgba(44,222,0,1);
+    }
+
+    .unknown {
+      border-radius: 50%;
+      background-color: #ffca00;
+      -webkit-box-shadow: 0 0 11px 1px rgb(255, 202, 0);
+      -moz-box-shadow: 0 0 11px 1px rgb(255, 202, 0);
+      box-shadow: 0 0 11px 1px rgb(255, 202, 0);
+    }
+
+    .failed {
+      border-radius: 50%;
+      background-color: #ff2600;
+      -webkit-box-shadow: 0 0 11px 1px rgba(222,0,0,1);
+      -moz-box-shadow: 0 0 11px 1px rgba(222,0,0,1);
+      box-shadow: 0 0 11px 1px rgba(222,0,0,1);
+    }
 
-  .result {
-    margin-right: 10px;
-    width: 10px;
-    height: 10px;
   }
 
-  .passed {
-    border-radius: 50%;
-    background-color: #8efa00;
-    -webkit-box-shadow: 0 0 11px 1px rgba(44,222,0,1);
-    -moz-box-shadow: 0 0 11px 1px rgba(44,222,0,1);
-    box-shadow: 0 0 11px 1px rgba(44,222,0,1);
+  #mark-as-solved-button {
+    margin-top: 20px;
   }
 
-  .unknown {
-    border-radius: 50%;
-    background-color: #ffca00;
-    -webkit-box-shadow: 0 0 11px 1px rgb(255, 202, 0);
-    -moz-box-shadow: 0 0 11px 1px rgb(255, 202, 0);
-    box-shadow: 0 0 11px 1px rgb(255, 202, 0);
+  #thank-you-container {
+    display: none;
+    margin-top: 20px;
+    padding: 5px;
+    border: solid lightgrey 1px;
+    background-color: rgba(20, 180, 20, 0.2);
+    border-radius: 4px;
+
+    button {
+      margin-right: 10px;
+    }
   }
 
-  .failed {
-    border-radius: 50%;
-    background-color: #ff2600;
-    -webkit-box-shadow: 0 0 11px 1px rgba(222,0,0,1);
-    -moz-box-shadow: 0 0 11px 1px rgba(222,0,0,1);
-    box-shadow: 0 0 11px 1px rgba(222,0,0,1);
+  #thank-you-note {
+    width: 100%;
+    height: 200px;
   }
-
-}
-
-#mark-as-solved-button {
-  margin-top: 20px;
-}
-
-#thank-you-container {
-  display: none;
-  margin-top: 20px;
-  padding: 5px;
-  border: solid lightgrey 1px;
-  background-color: rgba(20, 180, 20, 0.2);
-  border-radius: 4px;
-
-  button {
-    margin-right: 10px;
-  }
-}
-
-#thank-you-note {
-  width: 100%;
-  height: 200px;
 }
 
 #commentitor {
diff --git a/app/views/request_for_comments/show.html.erb b/app/views/request_for_comments/show.html.erb
index e4e83147..5f6a53f5 100644
--- a/app/views/request_for_comments/show.html.erb
+++ b/app/views/request_for_comments/show.html.erb
@@ -66,7 +66,13 @@
           <h5><%= t('request_for_comments.test_results') %></h5>
           <div class="testrun-assess-results">
             <% assess_runs.each do |testrun| %>
-                <div class="result <%= testrun.passed ? 'passed' : 'failed' %>" title="<%= testrun.output %>"></div>
+              <div class="testrun-container">
+                <div class="result <%= testrun.passed ? 'passed' : 'failed' %>"></div>
+                <div class="collapsed testrun-output text">
+                  <span class="fa fa-chevron-down collapse-button"></span>
+                  <pre><%= testrun.output or t('request_for_comments.no_output')%></pre>
+                </div>
+              </div>
             <% end %>
           </div>
         <% end %>