sped up some tests
This commit is contained in:
@@ -3,39 +3,41 @@ require 'rails_helper'
|
||||
describe CodeOcean::FilePolicy do
|
||||
subject { CodeOcean::FilePolicy }
|
||||
|
||||
let(:file) { FactoryGirl.build(:file) }
|
||||
let(:exercise) { FactoryGirl.create(:fibonacci) }
|
||||
let(:submission) { FactoryGirl.create(:submission) }
|
||||
|
||||
permissions :create? do
|
||||
context 'as part of an exercise' do
|
||||
before(:each) { file.context = exercise }
|
||||
before(:all) do
|
||||
@exercise = FactoryGirl.create(:fibonacci)
|
||||
@file = @exercise.files.first
|
||||
end
|
||||
|
||||
it 'grants access to admins' do
|
||||
expect(subject).to permit(FactoryGirl.build(:admin), file)
|
||||
expect(subject).to permit(FactoryGirl.build(:admin), @file)
|
||||
end
|
||||
|
||||
it 'grants access to authors' do
|
||||
expect(subject).to permit(exercise.author, file)
|
||||
expect(subject).to permit(@exercise.author, @file)
|
||||
end
|
||||
|
||||
it 'does not grant access to all other users' do
|
||||
[:external_user, :teacher].each do |factory_name|
|
||||
expect(subject).not_to permit(FactoryGirl.build(factory_name), file)
|
||||
expect(subject).not_to permit(FactoryGirl.build(factory_name), @file)
|
||||
end
|
||||
end
|
||||
end
|
||||
|
||||
context 'as part of a submission' do
|
||||
before(:each) { file.context = submission }
|
||||
before(:all) do
|
||||
@submission = FactoryGirl.create(:submission)
|
||||
@file = @submission.files.first
|
||||
end
|
||||
|
||||
it 'grants access to authors' do
|
||||
expect(subject).to permit(submission.author, file)
|
||||
expect(subject).to permit(@submission.author, @file)
|
||||
end
|
||||
|
||||
it 'does not grant access to all other users' do
|
||||
[:admin, :external_user, :teacher].each do |factory_name|
|
||||
expect(subject).not_to permit(FactoryGirl.build(factory_name), file)
|
||||
expect(subject).not_to permit(FactoryGirl.build(factory_name), @file)
|
||||
end
|
||||
end
|
||||
end
|
||||
@@ -43,29 +45,34 @@ describe CodeOcean::FilePolicy do
|
||||
|
||||
permissions :destroy? do
|
||||
context 'as part of an exercise' do
|
||||
before(:each) { file.context = exercise }
|
||||
before(:all) do
|
||||
@exercise = FactoryGirl.create(:fibonacci)
|
||||
@file = @exercise.files.first
|
||||
end
|
||||
|
||||
it 'grants access to admins' do
|
||||
expect(subject).to permit(FactoryGirl.build(:admin), file)
|
||||
expect(subject).to permit(FactoryGirl.build(:admin), @file)
|
||||
end
|
||||
|
||||
it 'grants access to authors' do
|
||||
expect(subject).to permit(exercise.author, file)
|
||||
expect(subject).to permit(@exercise.author, @file)
|
||||
end
|
||||
|
||||
it 'does not grant access to all other users' do
|
||||
[:external_user, :teacher].each do |factory_name|
|
||||
expect(subject).not_to permit(FactoryGirl.build(factory_name), file)
|
||||
expect(subject).not_to permit(FactoryGirl.build(factory_name), @file)
|
||||
end
|
||||
end
|
||||
end
|
||||
|
||||
context 'as part of a submission' do
|
||||
before(:each) { file.context = submission }
|
||||
before(:all) do
|
||||
@file = FactoryGirl.create(:submission).files.first
|
||||
end
|
||||
|
||||
it 'does not grant access to anyone' do
|
||||
[:admin, :external_user, :teacher].each do |factory_name|
|
||||
expect(subject).not_to permit(FactoryGirl.build(factory_name), file)
|
||||
expect(subject).not_to permit(FactoryGirl.build(factory_name), @file)
|
||||
end
|
||||
end
|
||||
end
|
||||
|
@@ -4,7 +4,7 @@ describe ExercisePolicy do
|
||||
subject { ExercisePolicy }
|
||||
|
||||
before(:all) do
|
||||
@exercise = FactoryGirl.build(:fibonacci, team: FactoryGirl.create(:team))
|
||||
@exercise = FactoryGirl.build(:dummy, team: FactoryGirl.create(:team))
|
||||
end
|
||||
|
||||
[:create?, :index?, :new?].each do |action|
|
||||
@@ -67,7 +67,7 @@ describe ExercisePolicy do
|
||||
[@admin, @teacher].each do |user|
|
||||
[true, false].each do |public|
|
||||
[@team, nil].each do |team|
|
||||
FactoryGirl.create(:fibonacci, public: public, team: team, user_id: user.id, user_type: InternalUser.class.name)
|
||||
FactoryGirl.create(:dummy, public: public, team: team, user_id: user.id, user_type: InternalUser.class.name)
|
||||
end
|
||||
end
|
||||
end
|
||||
|
@@ -19,7 +19,7 @@ describe SubmissionPolicy do
|
||||
|
||||
it 'grants access to authors' do
|
||||
user = FactoryGirl.create(:external_user)
|
||||
expect(subject).to permit(user, FactoryGirl.build(:submission, user_id: user.id, user_type: user.class.name))
|
||||
expect(subject).to permit(user, FactoryGirl.build(:submission, exercise: Exercise.new, user_id: user.id, user_type: user.class.name))
|
||||
end
|
||||
end
|
||||
end
|
||||
|
Reference in New Issue
Block a user