From b417231c12b6a0bfb1d752d9765e23df2d911f6a Mon Sep 17 00:00:00 2001 From: Ralf Teusner Date: Wed, 26 Aug 2015 11:51:33 +0200 Subject: [PATCH] a more defensive version of scoring to please the tests.. --- app/controllers/concerns/submission_scoring.rb | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/app/controllers/concerns/submission_scoring.rb b/app/controllers/concerns/submission_scoring.rb index bdffd2ed..081f0d01 100644 --- a/app/controllers/concerns/submission_scoring.rb +++ b/app/controllers/concerns/submission_scoring.rb @@ -26,8 +26,14 @@ module SubmissionScoring def score_submission(submission) outputs = collect_test_results(submission) - score = outputs.map { |output| - output[:score] * output[:weight] }.reduce(:+) + score = 0.0 + if not (outputs.nil? || outputs.empty?) + outputs.each do |output| + if not output.nil? + score += output[:score] * output[:weight] + end + end + end submission.update(score: score) outputs end