Rename v4 FontAwesome icons to match v5/v6 name

While FontAwesome provides aliases for all icons, we switch to the new names for consistency. See all changes at:
https://fontawesome.com/docs/web/setup/upgrade/upgrade-from-v4#icons-renamed-since-version-4

app/views/request_for_comments/_list_entry.html.slim

@@ -1,9 +1,9 @@
 tr.table-row-clickable data-id=request_for_comment.id data-href=request_for_comment_path(request_for_comment)
   td.p-2
     - if request_for_comment.solved?
-      span.fa.fa-check.fa-2x.text-success aria-hidden="true"
+      span.fa-solid.fa-check.fa-2x.text-success aria-hidden="true"
     - elsif request_for_comment.full_score_reached
-      span.fa.fa-check.fa-2x style="color:darkgrey" aria-hidden="true"
+      span.fa-solid.fa-check.fa-2x style="color:darkgrey" aria-hidden="true"
     - else
       = ''
   td.text-center = request_for_comment.comments_count

app/views/request_for_comments/index.html.slim

@@ -18,11 +18,11 @@ h1 = RequestForComment.model_name.human(count: 2)
     thead
       tr
         th
-          i class="fa fa-lightbulb-o" aria-hidden="true" title = t('request_for_comments.solved') align="right"
+          i class="fa-regular fa-lightbulb" aria-hidden="true" title = t('request_for_comments.solved') align="right"
         th =  sort_link(@search, :title,  t('activerecord.attributes.request_for_comments.exercise'))
         th = t('activerecord.attributes.request_for_comments.question')
         th
-          i class="fa fa-comment" aria-hidden="true" title = t('request_for_comments.comments') align="center"
+          i class="fa-solid fa-comment" aria-hidden="true" title = t('request_for_comments.comments') align="center"
         th = t('activerecord.attributes.request_for_comments.username')
         th = t('activerecord.attributes.request_for_comments.requested_at')
         th = t('activerecord.attributes.request_for_comments.last_update')
@@ -31,10 +31,10 @@ h1 = RequestForComment.model_name.human(count: 2)
         tr data-id=request_for_comment.id
           - if request_for_comment.solved?
             td
-              span class="fa fa-check" aria-hidden="true"
+              span class="fa-solid fa-check" aria-hidden="true"
           - elsif request_for_comment.full_score_reached
             td
-              span class="fa fa-check" style="color:darkgrey" aria-hidden="true"
+              span class="fa-solid fa-check" style="color:darkgrey" aria-hidden="true"
           - else
             td = ''
           td = link_to_if(policy(request_for_comment).show?, request_for_comment.exercise.title, request_for_comment)

app/views/request_for_comments/show.html.slim

@@ -1,7 +1,7 @@
 .list-group
   h4#exercise_caption.list-group-item-heading data-exercise-id="#{@request_for_comment.exercise.id}" data-rfc-id="#{@request_for_comment.id}"
     - if @request_for_comment.solved?
-      span.fa.fa-check aria-hidden="true"
+      span.fa-solid.fa-check aria-hidden="true"
     = link_to_if(policy(@request_for_comment.exercise).show?, @request_for_comment.exercise.title, [:implement, @request_for_comment.exercise])
   p.list-group-item-text
     - user = @request_for_comment.user
@@ -17,7 +17,7 @@
       h5
         = t('activerecord.attributes.exercise.description')
       .text
-        span.fa.fa-chevron-up.collapse-button
+        span.fa-solid.fa-chevron-up.collapse-button
         = render_markdown(@request_for_comment.exercise.description)
 
     .question
@@ -36,7 +36,7 @@
         - if output_runs.size > 0
           h5.mt-4= t('request_for_comments.runtime_output')
           .collapsed.testrun-output.text
-            span.fa.fa-chevron-down.collapse-button
+            span.fa-solid.fa-chevron-down.collapse-button
             - output_runs.each do |testrun|
               pre= testrun.log or t('request_for_comments.no_output')
 
@@ -50,7 +50,7 @@
               .testrun-container
                 div class=("result #{testrun.passed ? 'passed' : 'failed'}")
                 .collapsed.testrun-output.text
-                  span.fa.fa-chevron-down.collapse-button
+                  span.fa-solid.fa-chevron-down.collapse-button
                   pre= testrun.log or t('request_for_comments.no_output')
 
     - if @current_user.admin? && user.is_a?(ExternalUser)
@@ -72,7 +72,7 @@
   = (file.path or "") + "/" + file.name +  file.file_type.file_extension
   br/
   |   
-  i.fa.fa-arrow-down aria-hidden="true"
+  i.fa-solid.fa-arrow-down aria-hidden="true"
   = t('request_for_comments.click_here')
   #commentitor.editor data-file-id="#{file.id}" data-mode="#{file.file_type.editor_mode}" data-read-only="true"
     = file.content
@@ -180,7 +180,7 @@ javascript:
             <div class="comment-username">' + preprocess(comment.username) + '</div> \
             <div class="comment-date">' + comment.date + '</div> \
             <div class="comment-updated' + (comment.updated ? '' : ' d-none') + '"> \
-              <i class="fa fa-pencil" aria-hidden="true"></i> \
+              <i class="fa-solid fa-pencil" aria-hidden="true"></i> \
               #{{ t('request_for_comments.comment_edited') }} \
             </div> \
           </div> \