From b9fb743cf8584446c3c3c26d1650656a8a81a61f Mon Sep 17 00:00:00 2001 From: Thomas Hille Date: Wed, 12 Apr 2017 13:24:56 +0200 Subject: [PATCH] fix NaN exception if user attend spielweise --- app/models/proxy_exercise.rb | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/app/models/proxy_exercise.rb b/app/models/proxy_exercise.rb index 84f5e487..30cd7813 100644 --- a/app/models/proxy_exercise.rb +++ b/app/models/proxy_exercise.rb @@ -185,7 +185,12 @@ class ProxyExercise < ActiveRecord::Base private :scoring_matrix_quantiles def score(user, ex) - points_ratio = ex.maximum_score(user) / ex.maximum_score.to_f + max_score = ex.maximum_score.to_f + if max_score <= 0 + Rails.logger.debug("scoring user #{user.id} for exercise #{ex.id}: score: 0" ) + return 0.0 + end + points_ratio = ex.maximum_score(user) / max_score if points_ratio == 0.0 Rails.logger.debug("scoring user #{user.id} for exercise #{ex.id}: points_ratio=#{points_ratio} score: 0" ) return 0.0