htwkmooc/codeocean
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Change HTTP status codes for Poseidon in accordance with recent changes.

Browse Source 
See https://github.com/openHPI/poseidon/pull/159
This commit is contained in:
Sebastian Serth
2022-08-31 11:07:44 +02:00
committed by Sebastian Serth
parent 5f0229029c
commit ba821bd18b
2 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/runner/strategy/poseidon.rb
View File

@ -209,7 +209,7 @@ class Runner::Strategy::Poseidon < Runner::Strategy
raise Runner::Error::BadRequest.new(response_body[:message]) raise Runner::Error::BadRequest.new(response_body[:message])
when 401 when 401
raise Runner::Error::Unauthorized.new('Authentication with Poseidon failed') raise Runner::Error::Unauthorized.new('Authentication with Poseidon failed')
when 404 when 410
raise Runner::Error::RunnerNotFound.new raise Runner::Error::RunnerNotFound.new
when 500 when 500
response_body = parse response response_body = parse response

16
spec/lib/runner/strategy/poseidon_spec.rb
View File

@ -57,10 +57,10 @@ describe Runner::Strategy::Poseidon do
end end
end end
# All requests except creation handle a NotFound (404) response the same way. # All runner requests except creation handle a Gone (410) response the same way.
shared_examples 'NotFound (404) error handling' do shared_examples 'Gone (410) error handling' do
context 'when Poseidon returns NotFound (404)' do context 'when Poseidon returns NotFound (410)' do
let(:response_status) { 404 } let(:response_status) { 410 }
it 'raises an error' do it 'raises an error' do
expect { action.call }.to raise_error(Runner::Error::RunnerNotFound) expect { action.call }.to raise_error(Runner::Error::RunnerNotFound)
@ -293,7 +293,7 @@ describe Runner::Strategy::Poseidon do
include_examples 'BadRequest (400) error handling' include_examples 'BadRequest (400) error handling'
include_examples 'BadRequest (400) destroys local runner' include_examples 'BadRequest (400) destroys local runner'
include_examples 'Unauthorized (401) error handling' include_examples 'Unauthorized (401) error handling'
include_examples 'NotFound (404) error handling' include_examples 'Gone (410) error handling'
include_examples 'InternalServerError (500) error handling' include_examples 'InternalServerError (500) error handling'
include_examples 'unknown response status error handling' include_examples 'unknown response status error handling'
include_examples 'Faraday error handling' include_examples 'Faraday error handling'
@ -316,8 +316,8 @@ describe Runner::Strategy::Poseidon do
end end
end end
context 'when Poseidon returns NotFound (404)' do context 'when Poseidon returns Gone (410)' do
let(:response_status) { 404 } let(:response_status) { 410 }
it 'raises an error' do it 'raises an error' do
expect { action.call }.not_to raise_error expect { action.call }.not_to raise_error
@ -357,7 +357,7 @@ describe Runner::Strategy::Poseidon do
include_examples 'BadRequest (400) error handling' include_examples 'BadRequest (400) error handling'
include_examples 'BadRequest (400) destroys local runner' include_examples 'BadRequest (400) destroys local runner'
include_examples 'Unauthorized (401) error handling' include_examples 'Unauthorized (401) error handling'
include_examples 'NotFound (404) error handling' include_examples 'Gone (410) error handling'
include_examples 'InternalServerError (500) error handling' include_examples 'InternalServerError (500) error handling'
include_examples 'unknown response status error handling' include_examples 'unknown response status error handling'
include_examples 'Faraday error handling' include_examples 'Faraday error handling'