htwkmooc/codeocean
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove clear_lti_session_data as it is no longer needed

Browse Source 
* no lti session data anymore included in the function
* decided not to delete the pg_id here as it is handled in create_through_lti and implement
* the function is only called once without an exercise id so the values are now directly deleted there
This commit is contained in:
kiragrammel
2023-08-24 16:34:30 +02:00
committed by Sebastian Serth
parent dddebcca67
commit c2995c96f0
5 changed files with 8 additions and 42 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
app/controllers/concerns/lti.rb
View File

@@ -19,24 +19,6 @@ module Lti
private :build_tool_provider
# exercise_id.nil? ==> the user has logged out. All session data is to be destroyed
# exercise_id.exists? ==> the user has submitted the results of an exercise to the consumer.
# Only the assignment of the programming group is deleted.
def clear_lti_session_data(exercise_id = nil)
if exercise_id.nil?
session.delete(:external_user_id)
session.delete(:study_group_id)
session.delete(:embed_options)
end
session.delete(:pg_id)
# We allow reusing the LTI credentials and don't remove them on purpose.
# This allows users to jump between remote and web evaluation with the same behavior.
# Also it prevents the user from deleting the lti_parameters for their programming team members.
end
private :clear_lti_session_data
def consumer_return_url(provider, options = {})
consumer_return_url = provider.try(:launch_presentation_return_url) || params[:launch_presentation_return_url]
consumer_return_url += "?#{options.to_query}" if consumer_return_url && options.present?