htwkmooc/codeocean
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Only send one email per user when subscription gets a new comment

Browse Source
This commit is contained in:
Maximilian Grundke
2017-09-20 17:23:49 +02:00
parent be5b1df76a
commit c323205036
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/controllers/comments_controller.rb
View File

@ -121,14 +121,16 @@ class CommentsController < ApplicationController
def send_mail_to_subscribers(comment, request_for_comment) def send_mail_to_subscribers(comment, request_for_comment)
request_for_comment.commenters.each do |commenter| request_for_comment.commenters.each do |commenter|
already_sent_mail = false
subscriptions = Subscription.where( subscriptions = Subscription.where(
:request_for_comment_id => request_for_comment.id, :request_for_comment_id => request_for_comment.id,
:user_id => commenter.id, :user_type => commenter.class.name, :user_id => commenter.id, :user_type => commenter.class.name,
:deleted => false) :deleted => false)
subscriptions.each do |subscription| subscriptions.each do |subscription|
if (subscription.subscription_type == 'author' and current_user == request_for_comment.user) or subscription.subscription_type == 'all' if (subscription.subscription_type == 'author' and current_user == request_for_comment.user) or subscription.subscription_type == 'all'
if subscription.user != current_user unless subscription.user == current_user or already_sent_mail
UserMailer.got_new_comment_for_subscription(comment, subscription, current_user).deliver_now UserMailer.got_new_comment_for_subscription(comment, subscription, current_user).deliver_now
already_sent_mail = true
end end
end end
end end