From c3daa51c8c5b82c2d5663d25cd4d2aa279e3faf6 Mon Sep 17 00:00:00 2001 From: Sebastian Serth Date: Tue, 4 Oct 2022 14:45:04 +0200 Subject: [PATCH] SubmissionsController: Remove outdated `ActionController::Live` mixin The mixin was previously used for Server-Sent-Events, which were removed from CodeOcean a long time ago. After the mixin is removed, we can also fix the cookie send mechanism (this was erroneous with the mixin). --- app/controllers/submissions_controller.rb | 2 -- 1 file changed, 2 deletions(-) diff --git a/app/controllers/submissions_controller.rb b/app/controllers/submissions_controller.rb index 0024ba70..c1f1a8f0 100644 --- a/app/controllers/submissions_controller.rb +++ b/app/controllers/submissions_controller.rb @@ -1,7 +1,6 @@ # frozen_string_literal: true class SubmissionsController < ApplicationController - include ActionController::Live include CommonBehavior include Lti include SubmissionParameters @@ -87,7 +86,6 @@ class SubmissionsController < ApplicationController cookie_name = AuthenticatedUrlHelper.cookie_name_for(:render_file_token) if params[AuthenticatedUrlHelper.query_parameter].present? cookies[cookie_name] = AuthenticatedUrlHelper.prepare_short_living_cookie(request.url) - cookies.commit! end # Finally grant access and send the file