htwkmooc/codeocean
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix response format handling when creating a comment

Browse Source
This commit is contained in:
Sebastian Serth
2019-02-05 12:11:32 +01:00
parent f7030e3506
commit c74f2bd4ba
2 changed files with 14 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
app/controllers/comments_controller.rb
View File

@ -37,30 +37,26 @@ class CommentsController < ApplicationController
def create def create
@comment = Comment.new(comment_params_without_request_id) @comment = Comment.new(comment_params_without_request_id)
respond_to do |format| if @comment.save
if @comment.save if comment_params[:request_id]
if comment_params[:request_id] request_for_comment = RequestForComment.find(comment_params[:request_id])
request_for_comment = RequestForComment.find(comment_params[:request_id]) send_mail_to_author @comment, request_for_comment
send_mail_to_author @comment, request_for_comment send_mail_to_subscribers @comment, request_for_comment
send_mail_to_subscribers @comment, request_for_comment
end
render :show, status: :created, location: @comment
else
render json: @comment.errors, status: :unprocessable_entity
end end
render :show, status: :created, location: @comment
else
render json: @comment.errors, status: :unprocessable_entity
end end
authorize! authorize!
end end
# PATCH/PUT /comments/1.json # PATCH/PUT /comments/1.json
def update def update
respond_to do |format| if @comment.update(comment_params_without_request_id)
if @comment.update(comment_params_without_request_id) render :show, status: :ok, location: @comment
render :show, status: :ok, location: @comment else
else render json: @comment.errors, status: :unprocessable_entity
render json: @comment.errors, status: :unprocessable_entity
end
end end
authorize! authorize!
end end

2
config/routes.rb
View File

@ -26,7 +26,7 @@ Rails.application.routes.draw do
get '/my_rfc_activity', as: 'my_rfc_activity', to: 'request_for_comments#get_rfcs_with_my_comments' get '/my_rfc_activity', as: 'my_rfc_activity', to: 'request_for_comments#get_rfcs_with_my_comments'
delete '/comment_by_id', to: 'comments#destroy_by_id' delete '/comment_by_id', to: 'comments#destroy_by_id'
put '/comments', to: 'comments#update' put '/comments', to: 'comments#update', defaults: { format: :json }
resources :subscriptions, only: [:create, :destroy] do resources :subscriptions, only: [:create, :destroy] do
member do member do