From c8abe4681588dbc3b9ab1537e796ceaa32083eba Mon Sep 17 00:00:00 2001 From: yqbk Date: Wed, 8 Jun 2016 18:56:54 +0200 Subject: [PATCH] Problem with Error_controller_spec seemst to be connected with pundit. When we use version 0.3 instead of 1.1 all tests are passing. I have discovered that somehow error record is not correctly assigned in newer verion. Probably we need to look for an issue in spec/factories/error or app/models/error files. Tests are failing at the first step, when creating error -> @error = Error.new(params). Still hasn't solved but im quite close --- Gemfile | 2 +- Gemfile.lock | 6 +++--- spec/factories/error.rb | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/Gemfile b/Gemfile index 20b30e9c..94149b24 100644 --- a/Gemfile +++ b/Gemfile @@ -20,7 +20,7 @@ gem 'newrelic_rpm' gem 'pg', platform: :ruby gem 'pry-byebug' gem 'puma', '~> 2.15.3' -gem 'pundit' +gem 'pundit', '0.3' gem 'rails', '~> 4.1.13' gem 'rails-i18n', '~> 4.0.0' gem 'ransack' diff --git a/Gemfile.lock b/Gemfile.lock index aba77147..652dcc87 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -154,7 +154,7 @@ GEM method_source (0.8.2) mime-types (2.99) mini_portile2 (2.0.0) - minitest (5.8.4) + minitest (5.9.0) multi_json (1.11.2) multi_xml (0.5.5) multipart-post (2.0.0) @@ -195,7 +195,7 @@ GEM pry (~> 0.10) puma (2.15.3) puma (2.15.3-java) - pundit (1.1.0) + pundit (0.3.0) activesupport (>= 3.0.0) rack (1.5.5) rack-test (0.6.3) @@ -386,7 +386,7 @@ DEPENDENCIES pg pry-byebug puma (~> 2.15.3) - pundit + pundit (= 0.3) rails (~> 4.1.13) rails-i18n (~> 4.0.0) rake diff --git a/spec/factories/error.rb b/spec/factories/error.rb index 7207d345..235a90c0 100644 --- a/spec/factories/error.rb +++ b/spec/factories/error.rb @@ -1,5 +1,5 @@ FactoryGirl.define do - factory :error do + factory :error, class: Error do association :execution_environment, factory: :ruby message "exercise.rb:4:in `
': undefined local variable or method `foo' for main:Object (NameError)" end