clean pull request

This commit is contained in:
yqbk
2016-10-24 23:02:44 +02:00
parent 595a2a009b
commit c937a1a9ef
9 changed files with 13 additions and 32 deletions

View File

@ -18,7 +18,6 @@ describe SubmissionsController do
expect_assigns(submission: Submission)
it 'creates the submission' do
# pending("need to implement other pendings first")
expect { request.call }.to change(Submission, :count).by(1)
end
@ -189,7 +188,6 @@ describe SubmissionsController do
end
describe 'GET #score' do
let(:request) { proc { get :score, id: submission.id } }
before(:each) { request.call }

View File

@ -13,7 +13,6 @@ describe 'Editor', js: true do
end
it 'displays the exercise title' do
# pending("no exercise title set")
expect(page).to have_content(exercise.title)
end
@ -80,7 +79,6 @@ describe 'Editor', js: true do
let(:file) { exercise.files.detect { |file| !file.file_type.binary? } }
it "displays the file's code" do
pending("need to make travis working again")
expect(page).to have_css(".frame[data-filename='#{file.name_with_extension}']")
end
end

View File

@ -7,10 +7,8 @@ describe DockerClient, docker: true do
let(:execution_environment) { FactoryGirl.build(:ruby) }
let(:image) { double }
let(:submission) { FactoryGirl.create(:submission) }
# let(:workspace_path) { '/tmp/codeocean_dockertest' }
let(:workspace_path) { '/tmp' }
describe '.check_availability!' do
context 'when a socket error occurs' do
it 'raises an error' do

View File

@ -44,8 +44,6 @@ describe DockerContainerPool do
it 'takes a container from the pool' do
expect(described_class).not_to receive(:create_container).with(@execution_environment)
# #<Double (anonymous)> received unexpected message :json with (no args)
# expect(described_class).to receive(:json).with()
expect(described_class.get_container(@execution_environment)).to eq(container)
end
end
@ -62,7 +60,6 @@ describe DockerContainerPool do
end
end
context 'when inactive' do
before(:each) do
expect(described_class).to receive(:config).and_return(active: false)

View File

@ -21,7 +21,6 @@ describe ExecutionEnvironmentPolicy do
end
end
[:execute_command?, :shell?, :statistics?].each do |action|
permissions(action) do
it 'grants access to admins' do