htwkmooc/codeocean
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Slightly improve Statistics Controller performance

Browse Source
This commit is contained in:
Sebastian Serth
2023-02-21 01:00:30 +01:00
parent d0b713ddcd
commit d03f2c7bf4
2 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
app/helpers/statistics_helper.rb
View File

@ -43,9 +43,7 @@ module StatisticsHelper
{ {
key: 'currently_active', key: 'currently_active',
name: t('statistics.entries.users.currently_active'), name: t('statistics.entries.users.currently_active'),
data: ExternalUser.joins(:submissions) data: Submission.where(created_at: 5.minutes.ago.., user_type: ExternalUser.name).distinct.count(:user_id),
.where(['submissions.created_at >= ?', DateTime.now - 5.minutes])
.distinct('external_users.id').count,
url: statistics_graphs_path, url: statistics_graphs_path,
}, },
] ]
@ -81,6 +79,7 @@ module StatisticsHelper
{ {
key: 'container_requests_per_minute', key: 'container_requests_per_minute',
name: t('statistics.entries.exercises.container_requests_per_minute'), name: t('statistics.entries.exercises.container_requests_per_minute'),
# This query is actually quite expensive since we do not have an index on the created_at column.
data: (Testrun.where(created_at: DateTime.now - 1.hour..).count.to_f / 60).round(2), data: (Testrun.where(created_at: DateTime.now - 1.hour..).count.to_f / 60).round(2),
unit: '/min', unit: '/min',
}, },

2
app/models/request_for_comment.rb
View File

@ -17,7 +17,7 @@ class RequestForComment < ApplicationRecord
has_many :subscriptions, dependent: :destroy has_many :subscriptions, dependent: :destroy
scope :unsolved, -> { where(solved: [false, nil]) } scope :unsolved, -> { where(solved: [false, nil]) }
scope :in_range, ->(from, to) { where(created_at: from..to) } scope :in_range, ->(from, to) { from == DateTime.new(0) && to > 5.seconds.ago ? all : where(created_at: from..to) }
scope :with_comments, -> { select {|rfc| rfc.comments.any? } } scope :with_comments, -> { select {|rfc| rfc.comments.any? } }
# after_save :trigger_rfc_action_cable # after_save :trigger_rfc_action_cable