htwkmooc/codeocean
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Reduce SQL queries for RfC index actions

Browse Source 
By using includes and carefully selecting objects through references, all required objects are only queried once.
This commit is contained in:
Sebastian Serth
2023-02-20 09:36:35 +01:00
parent 76f592c88d
commit d0717fb178
2 changed files with 13 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
app/controllers/request_for_comments_controller.rb
View File

@ -22,9 +22,10 @@ class RequestForCommentsController < ApplicationController
@request_for_comments = @search.result
.joins(:exercise)
.where(exercises: {unpublished: false})
.includes(submission: [:study_group])
.order('created_at DESC')
.paginate(page: params[:page], per_page: per_page_param, total_entries: @search.result.length)
.includes(submission: %i[study_group exercise])
.includes(:file, :comments, :user)
.order(created_at: :desc)
.paginate(page: params[:page], per_page: per_page_param)
authorize!
end
@ -36,7 +37,9 @@ class RequestForCommentsController < ApplicationController
.where(user: current_user)
.ransack(params[:q])
@request_for_comments = @search.result
.order('created_at DESC')
.includes(submission: %i[study_group exercise])
.includes(:file, :comments, :user)
.order(created_at: :desc)
.paginate(page: params[:page], per_page: per_page_param)
authorize!
render 'index'
@ -47,10 +50,12 @@ class RequestForCommentsController < ApplicationController
@search = policy_scope(RequestForComment)
.with_last_activity
.joins(:comments) # we don't need to outer join here, because we know the user has commented on these
.where(comments: {user_id: current_user.id})
.where(comments: {user: current_user})
.ransack(params[:q])
@request_for_comments = @search.result
.order('last_comment DESC')
.includes(submission: [:study_group, :exercise, {files: %i[comments]}])
.includes(:user)
.order(last_comment: :desc)
.paginate(page: params[:page], per_page: per_page_param)
authorize!
render 'index'
@ -65,7 +70,7 @@ class RequestForCommentsController < ApplicationController
.ransack(params[:q])
@request_for_comments = @search.result
.joins(:exercise)
.order('last_comment DESC')
.order(last_comment: :desc)
.paginate(page: params[:page], per_page: per_page_param)
# let the exercise decide, whether its rfcs should be visible
authorize(exercise)