changed database cleaning strategy

spec/policies/code_ocean/file_policy_spec.rb

@@ -3,41 +3,38 @@ require 'rails_helper'
 describe CodeOcean::FilePolicy do
   subject { described_class }
 
+  let(:exercise) { FactoryGirl.create(:fibonacci) }
+  let(:submission) { FactoryGirl.create(:submission) }
+
   permissions :create? do
     context 'as part of an exercise' do
-      before(:all) do
-        @exercise = FactoryGirl.create(:fibonacci)
-        @file = @exercise.files.first
-      end
+      let(:file) { exercise.files.first }
 
       it 'grants access to admins' do
-        expect(subject).to permit(FactoryGirl.build(:admin), @file)
+        expect(subject).to permit(FactoryGirl.build(:admin), file)
       end
 
       it 'grants access to authors' do
-        expect(subject).to permit(@exercise.author, @file)
+        expect(subject).to permit(exercise.author, file)
       end
 
       it 'does not grant access to all other users' do
         [:external_user, :teacher].each do |factory_name|
-          expect(subject).not_to permit(FactoryGirl.build(factory_name), @file)
+          expect(subject).not_to permit(FactoryGirl.build(factory_name), file)
         end
       end
     end
 
     context 'as part of a submission' do
-      before(:all) do
-        @submission = FactoryGirl.create(:submission)
-        @file = @submission.files.first
-      end
+      let(:file) { submission.files.first }
 
       it 'grants access to authors' do
-        expect(subject).to permit(@submission.author, @file)
+        expect(subject).to permit(submission.author, file)
       end
 
       it 'does not grant access to all other users' do
         [:admin, :external_user, :teacher].each do |factory_name|
-          expect(subject).not_to permit(FactoryGirl.build(factory_name), @file)
+          expect(subject).not_to permit(FactoryGirl.build(factory_name), file)
         end
       end
     end
@@ -45,34 +42,29 @@ describe CodeOcean::FilePolicy do
 
   permissions :destroy? do
     context 'as part of an exercise' do
-      before(:all) do
-        @exercise = FactoryGirl.create(:fibonacci)
-        @file = @exercise.files.first
-      end
+      let(:file) { exercise.files.first }
 
       it 'grants access to admins' do
-        expect(subject).to permit(FactoryGirl.build(:admin), @file)
+        expect(subject).to permit(FactoryGirl.build(:admin), file)
       end
 
       it 'grants access to authors' do
-        expect(subject).to permit(@exercise.author, @file)
+        expect(subject).to permit(exercise.author, file)
       end
 
       it 'does not grant access to all other users' do
         [:external_user, :teacher].each do |factory_name|
-          expect(subject).not_to permit(FactoryGirl.build(factory_name), @file)
+          expect(subject).not_to permit(FactoryGirl.build(factory_name), file)
         end
       end
     end
 
     context 'as part of a submission' do
-      before(:all) do
-        @file = FactoryGirl.create(:submission).files.first
-      end
+      let(:file) { submission.files.first }
 
       it 'does not grant access to anyone' do
         [:admin, :external_user, :teacher].each do |factory_name|
-          expect(subject).not_to permit(FactoryGirl.build(factory_name), @file)
+          expect(subject).not_to permit(FactoryGirl.build(factory_name), file)
         end
       end
     end