added tests

spec/controllers/submissions_controller_spec.rb

@@ -42,9 +42,12 @@ describe SubmissionsController do
     end
 
     context 'with a valid filename' do
-      let(:file) { submission.files.first }
+      let(:submission) { FactoryGirl.create(:submission, exercise: FactoryGirl.create(:audio_video)) }
       before(:each) { get :download_file, filename: file.name_with_extension, id: submission.id }
 
+      context 'for a binary file' do
+        let(:file) { submission.collect_files.detect { |file| file.file_type.file_extension == '.mp4' } }
+
         expect_assigns(file: :file)
         expect_assigns(submission: :submission)
         expect_content_type('application/octet-stream')
@@ -54,6 +57,20 @@ describe SubmissionsController do
           expect(response.headers['Content-Disposition']).to eq("attachment; filename=\"#{file.name_with_extension}\"")
         end
       end
+
+      context 'for a non-binary file' do
+        let(:file) { submission.collect_files.detect { |file| file.file_type.file_extension == '.js' } }
+
+        expect_assigns(file: :file)
+        expect_assigns(submission: :submission)
+        expect_content_type('text/javascript')
+        expect_status(200)
+
+        it 'sets the correct filename' do
+          expect(response.headers['Content-Disposition']).to eq("attachment; filename=\"#{file.name_with_extension}\"")
+        end
+      end
+    end
   end
 
   describe 'GET #index' do
@@ -75,10 +92,28 @@ describe SubmissionsController do
     end
 
     context 'with a valid filename' do
+      let(:submission) { FactoryGirl.create(:submission, exercise: FactoryGirl.create(:audio_video)) }
       before(:each) { get :render_file, filename: file.name_with_extension, id: submission.id }
 
+      context 'for a binary file' do
+        let(:file) { submission.collect_files.detect { |file| file.file_type.file_extension == '.mp4' } }
+
         expect_assigns(file: :file)
         expect_assigns(submission: :submission)
+        expect_content_type('application/octet-stream')
+        expect_status(200)
+
+        it 'renders the file content' do
+          expect(response.body).to eq(file.native_file.read)
+        end
+      end
+
+      context 'for a non-binary file' do
+        let(:file) { submission.collect_files.detect { |file| file.file_type.file_extension == '.js' } }
+
+        expect_assigns(file: :file)
+        expect_assigns(submission: :submission)
+        expect_content_type('text/javascript')
         expect_status(200)
 
         it 'renders the file content' do
@@ -86,6 +121,7 @@ describe SubmissionsController do
         end
       end
     end
+  end
 
   describe 'GET #run' do
     let(:filename) { submission.collect_files.detect(&:main_file?).name_with_extension }
@@ -147,6 +183,15 @@ describe SubmissionsController do
     expect_template(:show)
   end
 
+  describe 'GET #score' do
+    let(:request) { proc { get :score, id: submission.id } }
+    before(:each) { request.call }
+
+    expect_assigns(submission: :submission)
+    expect_json
+    expect_status(200)
+  end
+
   describe 'GET #test' do
     let(:filename) { submission.collect_files.detect(&:teacher_defined_test?).name_with_extension }
     let(:output) { {} }