From d9f40531fbab2540a7acd236766010c47083db68 Mon Sep 17 00:00:00 2001 From: Sebastian Serth Date: Wed, 20 Apr 2022 18:09:15 +0200 Subject: [PATCH] Fix Rubocop offenses --- spec/concerns/lti_spec.rb | 2 +- .../execution_environments_controller_spec.rb | 6 +++--- spec/controllers/sessions_controller_spec.rb | 2 +- spec/helpers/admin/dashboard_helper_spec.rb | 2 +- spec/lib/runner/strategy/poseidon_spec.rb | 10 +++++----- spec/models/execution_environment_spec.rb | 2 +- spec/services/proforma_service/export_task_spec.rb | 2 +- 7 files changed, 13 insertions(+), 13 deletions(-) diff --git a/spec/concerns/lti_spec.rb b/spec/concerns/lti_spec.rb index 9423a951..12abed30 100644 --- a/spec/concerns/lti_spec.rb +++ b/spec/concerns/lti_spec.rb @@ -33,7 +33,7 @@ describe Lti do let(:last_name) { 'Doe' } let(:full_name) { 'John Doe' } let(:provider) { double } - let(:provider_full) { instance_double('IMS::LTI::ToolProvider', lis_person_name_full: full_name) } + let(:provider_full) { instance_double(IMS::LTI::ToolProvider, lis_person_name_full: full_name) } context 'when a full name is provided' do it 'returns the full name' do diff --git a/spec/controllers/execution_environments_controller_spec.rb b/spec/controllers/execution_environments_controller_spec.rb index 9f34792c..8ab91cc6 100644 --- a/spec/controllers/execution_environments_controller_spec.rb +++ b/spec/controllers/execution_environments_controller_spec.rb @@ -18,7 +18,7 @@ describe ExecutionEnvironmentsController do before do allow(Rails.env).to receive(:test?).and_return(false, true) allow(Runner.strategy_class).to receive(:sync_environment).and_return(true) - runner = instance_double 'runner' + runner = instance_double Runner allow(Runner).to receive(:for).and_return(runner) allow(runner).to receive(:execute_command).and_return({}) perform_request.call @@ -90,7 +90,7 @@ describe ExecutionEnvironmentsController do let(:command) { 'which ruby' } before do - runner = instance_double 'runner' + runner = instance_double Runner allow(Runner).to receive(:for).with(user, execution_environment).and_return runner allow(runner).to receive(:execute_command).and_return({}) post :execute_command, params: {command: command, id: execution_environment.id} @@ -183,7 +183,7 @@ describe ExecutionEnvironmentsController do before do allow(Rails.env).to receive(:test?).and_return(false, true) allow(Runner.strategy_class).to receive(:sync_environment).and_return(true) - runner = instance_double 'runner' + runner = instance_double Runner allow(Runner).to receive(:for).and_return(runner) allow(runner).to receive(:execute_command).and_return({}) put :update, params: {execution_environment: attributes_for(:ruby, pool_size: 1), id: execution_environment.id} diff --git a/spec/controllers/sessions_controller_spec.rb b/spec/controllers/sessions_controller_spec.rb index 4b7b54c0..3cf9b490 100644 --- a/spec/controllers/sessions_controller_spec.rb +++ b/spec/controllers/sessions_controller_spec.rb @@ -86,7 +86,7 @@ describe SessionsController do it 'sets the specified locale' do expect(controller).to receive(:switch_locale).and_call_original - i18n = instance_double 'i18n', locale: locale.to_s + i18n = class_double I18n, locale: locale.to_s allow(I18n).to receive(:locale=).with(I18n.default_locale).and_call_original allow(I18n).to receive(:locale=).with(locale.to_s).and_return(i18n) perform_request diff --git a/spec/helpers/admin/dashboard_helper_spec.rb b/spec/helpers/admin/dashboard_helper_spec.rb index 64307b83..e82371f3 100644 --- a/spec/helpers/admin/dashboard_helper_spec.rb +++ b/spec/helpers/admin/dashboard_helper_spec.rb @@ -12,7 +12,7 @@ describe Admin::DashboardHelper do describe '#docker_data' do before do create(:ruby) - dcp = instance_double 'docker_container_pool' + dcp = class_double Runner::Strategy::DockerContainerPool allow(Runner).to receive(:strategy_class).and_return dcp allow(dcp).to receive(:pool_size).and_return({}) end diff --git a/spec/lib/runner/strategy/poseidon_spec.rb b/spec/lib/runner/strategy/poseidon_spec.rb index 92c1da28..c4806587 100644 --- a/spec/lib/runner/strategy/poseidon_spec.rb +++ b/spec/lib/runner/strategy/poseidon_spec.rb @@ -118,7 +118,7 @@ describe Runner::Strategy::Poseidon do let(:response_status) { -1 } it 'raises an error' do - faraday_connection = instance_double 'Faraday::Connection' + faraday_connection = instance_double Faraday::Connection allow(described_class).to receive(:http_connection).and_return(faraday_connection) %i[post patch delete].each {|message| allow(faraday_connection).to receive(message).and_raise(Faraday::TimeoutError) } expect { action.call }.to raise_error(Runner::Error::FaradayError) @@ -131,7 +131,7 @@ describe Runner::Strategy::Poseidon do let(:execution_environment) { create(:ruby) } it 'makes the correct request to Poseidon' do - faraday_connection = instance_double 'Faraday::Connection' + faraday_connection = instance_double Faraday::Connection allow(described_class).to receive(:http_connection).and_return(faraday_connection) allow(faraday_connection).to receive(:put).and_return(Faraday::Response.new(status: 201)) action.call @@ -143,7 +143,7 @@ describe Runner::Strategy::Poseidon do shared_examples 'returns true when the api request was successful' do |status| it "returns true on status #{status}" do - faraday_connection = instance_double 'Faraday::Connection' + faraday_connection = instance_double Faraday::Connection allow(described_class).to receive(:http_connection).and_return(faraday_connection) allow(faraday_connection).to receive(:put).and_return(Faraday::Response.new(status: status)) expect(action.call).to be_truthy @@ -152,7 +152,7 @@ describe Runner::Strategy::Poseidon do shared_examples 'returns false when the api request failed' do |status| it "raises an exception on status #{status}" do - faraday_connection = instance_double 'Faraday::Connection' + faraday_connection = instance_double Faraday::Connection allow(described_class).to receive(:http_connection).and_return(faraday_connection) allow(faraday_connection).to receive(:put).and_return(Faraday::Response.new(status: status)) expect { action.call }.to raise_exception Runner::Error::UnexpectedResponse @@ -168,7 +168,7 @@ describe Runner::Strategy::Poseidon do end it 'raises an exception if Faraday raises an error' do - faraday_connection = instance_double 'Faraday::Connection' + faraday_connection = instance_double Faraday::Connection allow(described_class).to receive(:http_connection).and_return(faraday_connection) allow(faraday_connection).to receive(:put).and_raise(Faraday::TimeoutError) expect { action.call }.to raise_exception Runner::Error::FaradayError diff --git a/spec/models/execution_environment_spec.rb b/spec/models/execution_environment_spec.rb index 05ef6666..dc11094d 100644 --- a/spec/models/execution_environment_spec.rb +++ b/spec/models/execution_environment_spec.rb @@ -153,7 +153,7 @@ describe ExecutionEnvironment do describe '#working_docker_image?' do let(:execution_environment) { create(:ruby) } let(:working_docker_image?) { execution_environment.send(:working_docker_image?) } - let(:runner) { instance_double 'runner' } + let(:runner) { instance_double Runner } before do allow(execution_environment).to receive(:sync_runner_environment).and_return(true) diff --git a/spec/services/proforma_service/export_task_spec.rb b/spec/services/proforma_service/export_task_spec.rb index 3937f08a..ed4b5fdf 100644 --- a/spec/services/proforma_service/export_task_spec.rb +++ b/spec/services/proforma_service/export_task_spec.rb @@ -26,7 +26,7 @@ describe ProformaService::ExportTask do let(:task) { Proforma::Task.new } let(:exercise) { build(:dummy) } - let(:exporter) { instance_double('Proforma::Exporter', perform: 'zip') } + let(:exporter) { instance_double(Proforma::Exporter, perform: 'zip') } before do allow(ProformaService::ConvertExerciseToTask).to receive(:call).with(exercise: exercise).and_return(task)