review points

spec/policies/codeharbor_link_policy_spec.rb

@@ -18,13 +18,13 @@ describe CodeharborLinkPolicy do
   %i[new? create?].each do |action|
     permissions(action) do
       it 'grants access to teachers' do
-        expect(policy).to permit(FactoryBot.create(:teacher), codeharbor_link)
+        %i[teacher admin].each do |factory_name|
+          expect(policy).to permit(FactoryBot.create(factory_name), codeharbor_link)
+        end
       end
 
       it 'does not grant access to all other users' do
-        %i[external_user admin].each do |factory_name|
-          expect(policy).not_to permit(FactoryBot.create(factory_name), codeharbor_link)
-        end
+        expect(policy).not_to permit(FactoryBot.create(:external_user), codeharbor_link)
       end
     end
   end