Adjust default message for linter / unit test
This commit is contained in:
@ -29,7 +29,7 @@ module SubmissionScoring
|
|||||||
waiting_for_container_time: output[:waiting_for_container_time]
|
waiting_for_container_time: output[:waiting_for_container_time]
|
||||||
).save
|
).save
|
||||||
output.merge!(assessment)
|
output.merge!(assessment)
|
||||||
output.merge!(filename: file.name_with_extension, message: feedback_message(file, output[:score]), weight: file.weight)
|
output.merge!(filename: file.name_with_extension, message: feedback_message(file, output), weight: file.weight)
|
||||||
# end
|
# end
|
||||||
end
|
end
|
||||||
future.value
|
future.value
|
||||||
@ -45,9 +45,15 @@ module SubmissionScoring
|
|||||||
|
|
||||||
private :execute_test_file
|
private :execute_test_file
|
||||||
|
|
||||||
def feedback_message(file, score)
|
def feedback_message(file, output)
|
||||||
set_locale
|
set_locale
|
||||||
score == Assessor::MAXIMUM_SCORE ? I18n.t('exercises.implement.default_feedback') : render_markdown(file.feedback_message)
|
if output[:score] == Assessor::MAXIMUM_SCORE && output[:file_role] == 'teacher_defined_test'
|
||||||
|
I18n.t('exercises.implement.default_test_feedback')
|
||||||
|
elsif output[:score] == Assessor::MAXIMUM_SCORE && output[:file_role] == 'teacher_defined_linter'
|
||||||
|
I18n.t('exercises.implement.default_linter_feedback')
|
||||||
|
else
|
||||||
|
render_markdown(file.feedback_message)
|
||||||
|
end
|
||||||
end
|
end
|
||||||
|
|
||||||
def score_submission(submission)
|
def score_submission(submission)
|
||||||
|
@ -366,7 +366,8 @@ de:
|
|||||||
alert:
|
alert:
|
||||||
text: 'Ihr Browser unterstützt nicht alle Funktionalitäten, die %{application_name} benötigt. Bitte nutzen Sie einen modernen Browser, um %{application_name} zu besuchen.'
|
text: 'Ihr Browser unterstützt nicht alle Funktionalitäten, die %{application_name} benötigt. Bitte nutzen Sie einen modernen Browser, um %{application_name} zu besuchen.'
|
||||||
title: Ihr Browser wird nicht unterstützt!
|
title: Ihr Browser wird nicht unterstützt!
|
||||||
default_feedback: Sehr gut. Alle Tests waren erfolgreich.
|
default_test_feedback: Sehr gut. Alle Tests waren erfolgreich.
|
||||||
|
default_linter_feedback: Sehr gut. Der Linter hat nichts mehr zu beanstanden.
|
||||||
error_messages: Fehlermeldungen
|
error_messages: Fehlermeldungen
|
||||||
messages: Meldungen
|
messages: Meldungen
|
||||||
feedback: Feedback
|
feedback: Feedback
|
||||||
|
@ -366,7 +366,8 @@ en:
|
|||||||
alert:
|
alert:
|
||||||
text: 'Your browser does not support features required for using %{application_name}. Please access %{application_name} using a modern browser.'
|
text: 'Your browser does not support features required for using %{application_name}. Please access %{application_name} using a modern browser.'
|
||||||
title: Your browser is not supported!
|
title: Your browser is not supported!
|
||||||
default_feedback: Well done. All tests have been passed.
|
default_test_feedback: Well done. All tests have been passed.
|
||||||
|
default_linter_feedback: Well done. The linter is completly satisfied.
|
||||||
error_messages: Error Messages
|
error_messages: Error Messages
|
||||||
messages: Messages
|
messages: Messages
|
||||||
feedback: Feedback
|
feedback: Feedback
|
||||||
|
Reference in New Issue
Block a user