From e2c8156f0e39224f02ad90922dd16ed6df14559e Mon Sep 17 00:00:00 2001
From: Sebastian Serth <Sebastian.Serth@hpi.de>
Date: Thu, 21 Dec 2023 17:14:22 +0100
Subject: [PATCH] Simplify forEach loops in JavaScript

See https://stackoverflow.com/a/9329476
---
 app/assets/javascripts/editor/editor.js.erb | 7 ++-----
 app/assets/javascripts/exercises.js.erb     | 9 ++++-----
 2 files changed, 6 insertions(+), 10 deletions(-)

diff --git a/app/assets/javascripts/editor/editor.js.erb b/app/assets/javascripts/editor/editor.js.erb
index 45260862..c8e8a2bf 100644
--- a/app/assets/javascripts/editor/editor.js.erb
+++ b/app/assets/javascripts/editor/editor.js.erb
@@ -586,10 +586,7 @@ var CodeOceanEditor = {
                     return map;
                 }, {});
 
-                for (let severity in severity_groups) {
-                    if (!severity_groups.hasOwnProperty(severity)) {
-                        continue;
-                    }
+                for (const severity of severity_groups) {
                     const linter_results = severity_groups[severity]
 
                     const li = document.createElement("li");
@@ -599,7 +596,7 @@ var CodeOceanEditor = {
 
                     const sub_ul = document.createElement("ul");
                     sub_ul.setAttribute('class', 'inline_list');
-                    for (let check_run of linter_results) {
+                    for (const check_run of linter_results) {
                         const sub_li = document.createElement("li");
 
                         let scope = '';
diff --git a/app/assets/javascripts/exercises.js.erb b/app/assets/javascripts/exercises.js.erb
index ab0f14a0..4f9deb8a 100644
--- a/app/assets/javascripts/exercises.js.erb
+++ b/app/assets/javascripts/exercises.js.erb
@@ -191,12 +191,11 @@ $(document).on('turbolinks:load', function () {
 
         function serialize(sortable) {
             let serialized = [];
-            const children = [].slice.call(sortable.children);
-            for (let i in children) {
-                const nested = children[i].querySelector(nestedQuery);
+            for (const child of sortable.children) {
+                const nested = child.querySelector(nestedQuery);
                 serialized.push({
-                    tip_id: children[i].dataset['tipId'],
-                    id: children[i].dataset['id'],
+                    tip_id: child.dataset['tipId'],
+                    id: child.dataset['id'],
                     children: nested ? serialize(nested) : []
                 });
             }