Simplify permission specs

* Remove iteration if not required
* Unify usage of parentheses for `permissions` call
This commit is contained in:
Sebastian Serth
2022-08-22 13:15:52 +02:00
committed by Sebastian Serth
parent e0c2c7b806
commit e5879eb606
4 changed files with 37 additions and 47 deletions

View File

@ -7,19 +7,17 @@ describe ExecutionEnvironmentPolicy do
let(:execution_environment) { build(:ruby) }
[:index?].each do |action|
permissions(action) do
it 'grants access to admins' do
expect(policy).to permit(build(:admin), execution_environment)
end
permissions :index? do
it 'grants access to admins' do
expect(policy).to permit(build(:admin), execution_environment)
end
it 'grants access to teachers' do
expect(policy).to permit(build(:teacher), execution_environment)
end
it 'grants access to teachers' do
expect(policy).to permit(build(:teacher), execution_environment)
end
it 'does not grant access to external users' do
expect(policy).not_to permit(build(:external_user), execution_environment)
end
it 'does not grant access to external users' do
expect(policy).not_to permit(build(:external_user), execution_environment)
end
end
@ -59,7 +57,7 @@ describe ExecutionEnvironmentPolicy do
end
end
permissions(:sync_all_to_runner_management?) do
permissions :sync_all_to_runner_management? do
it 'grants access to the admin' do
expect(policy).to permit(build(:admin))
end