Simplify permission specs

* Remove iteration if not required
* Unify usage of parentheses for `permissions` call
This commit is contained in:
Sebastian Serth
2022-08-22 13:15:52 +02:00
committed by Sebastian Serth
parent e0c2c7b806
commit e5879eb606
4 changed files with 37 additions and 47 deletions

View File

@ -16,14 +16,12 @@ describe ExternalUserPolicy do
end
end
[:index?].each do |action|
permissions(action) do
it 'grants access to admins and teachers only' do
expect(policy).to permit(build(:admin), ExternalUser.new)
expect(policy).to permit(build(:teacher), ExternalUser.new)
[:external_user].each do |factory_name|
expect(policy).not_to permit(build(factory_name), ExternalUser.new)
end
permissions :index? do
it 'grants access to admins and teachers only' do
expect(policy).to permit(build(:admin), ExternalUser.new)
expect(policy).to permit(build(:teacher), ExternalUser.new)
[:external_user].each do |factory_name|
expect(policy).not_to permit(build(factory_name), ExternalUser.new)
end
end
end