htwkmooc/codeocean
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

working_docker_image?: Modify behavior to match spec

Browse Source
This commit is contained in:
Sebastian Serth
2018-02-22 01:03:06 +01:00
parent 2a38db6e75
commit e70897e560
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/models/execution_environment.rb
View File

@ -47,7 +47,7 @@ class ExecutionEnvironment < ActiveRecord::Base
private :validate_docker_image? private :validate_docker_image?
def working_docker_image? def working_docker_image?
DockerClient.pull(docker_image) unless DockerClient.image_tags.include?(docker_image) DockerClient.pull(docker_image) unless DockerClient.find_image_by_tag(docker_image).blank?
output = DockerClient.new(execution_environment: self).execute_arbitrary_command(VALIDATION_COMMAND) output = DockerClient.new(execution_environment: self).execute_arbitrary_command(VALIDATION_COMMAND)
errors.add(:docker_image, "error: #{output[:stderr]}") if output[:stderr].present? errors.add(:docker_image, "error: #{output[:stderr]}") if output[:stderr].present?
rescue DockerClient::Error => error rescue DockerClient::Error => error