htwkmooc/codeocean
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Refactor send_thank_you_note method and according specs

Browse Source
This commit is contained in:
Janis Vaneylen
2022-09-02 14:23:42 +02:00
committed by Sebastian Serth
parent 60dc8c3b7e
commit e77223e628
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/mailers/user_mailer.rb
View File

@ -45,7 +45,7 @@ class UserMailer < ApplicationMailer
end end
def send_thank_you_note(request_for_comment, receiver) def send_thank_you_note(request_for_comment, receiver)
token = AuthenticationToken.generate!(request_for_comment.user) token = AuthenticationToken.generate!(receiver)
@receiver_displayname = receiver.displayname @receiver_displayname = receiver.displayname
@author = request_for_comment.user.displayname @author = request_for_comment.user.displayname
@thank_you_note = request_for_comment.thank_you_note @thank_you_note = request_for_comment.thank_you_note

4
spec/mailers/user_mailer_spec.rb
View File

@ -132,9 +132,9 @@ describe UserMailer do
describe '#send_thank_you_note' do describe '#send_thank_you_note' do
let(:user) { create(:learner) } let(:user) { create(:learner) }
let(:token) { AuthenticationToken.find_by(user: user) } let(:receiver) { create(:teacher) }
let(:token) { AuthenticationToken.find_by(user: receiver) }
let(:request_for_comments) { create(:rfc_with_comment, user: user) } let(:request_for_comments) { create(:rfc_with_comment, user: user) }
let(:receiver) { InternalUser.create(attributes_for(:teacher)) }
let(:mail) { described_class.send_thank_you_note(request_for_comments, receiver).deliver_now } let(:mail) { described_class.send_thank_you_note(request_for_comments, receiver).deliver_now }
it 'sets the correct sender' do it 'sets the correct sender' do