Update bundle (with newest rubocop version) and fix offenses

spec/concerns/file_parameters_spec.rb

@@ -8,11 +8,11 @@ end
 
 describe FileParameters do
   let(:controller) { Controller.new }
-  let(:hello_world) { FactoryBot.create(:hello_world) }
+  let(:hello_world) { create(:hello_world) }
 
   describe '#reject_illegal_file_attributes!' do
     def file_accepted?(file)
-      files = [[0, FactoryBot.attributes_for(:file, context: hello_world, file_id: file.id)]]
+      files = [[0, attributes_for(:file, context: hello_world, file_id: file.id)]]
       filtered_files = controller.send(:reject_illegal_file_attributes, hello_world, files)
       files.eql?(filtered_files)
     end
@@ -24,31 +24,31 @@ describe FileParameters do
       end
 
       it 'new file' do
-        submission = FactoryBot.create(:submission, exercise: hello_world, id: 1337)
-        new_file = FactoryBot.create(:file, context: submission)
+        submission = create(:submission, exercise: hello_world, id: 1337)
+        new_file = create(:file, context: submission)
         expect(file_accepted?(new_file)).to be true
       end
     end
 
     describe 'rejects' do
       it 'file of different exercise' do
-        fibonacci = FactoryBot.create(:fibonacci, allow_file_creation: true)
-        other_exercises_file = FactoryBot.create(:file, context: fibonacci)
+        fibonacci = create(:fibonacci, allow_file_creation: true)
+        other_exercises_file = create(:file, context: fibonacci)
         expect(file_accepted?(other_exercises_file)).to be false
       end
 
       it 'hidden file' do
-        hidden_file = FactoryBot.create(:file, context: hello_world, hidden: true)
+        hidden_file = create(:file, context: hello_world, hidden: true)
         expect(file_accepted?(hidden_file)).to be false
       end
 
       it 'read only file' do
-        read_only_file = FactoryBot.create(:file, context: hello_world, read_only: true)
+        read_only_file = create(:file, context: hello_world, read_only: true)
         expect(file_accepted?(read_only_file)).to be false
       end
 
       it 'non existent file' do
-        non_existent_file = FactoryBot.build(:file, context: hello_world, id: 42)
+        non_existent_file = build(:file, context: hello_world, id: 42)
         expect(file_accepted?(non_existent_file)).to be false
       end
     end