htwkmooc/codeocean
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Update bundle (with newest rubocop version) and fix offenses

Browse Source
This commit is contained in:
Sebastian Serth
2022-01-03 18:11:17 +01:00
parent 57e32611ed
commit ea85519163
93 changed files with 968 additions and 985 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
spec/policies/admin/dashboard_policy_spec.rb
View File

@ -7,15 +7,15 @@ describe Admin::DashboardPolicy do
permissions :show? do
it 'grants access to admins' do
expect(policy).to permit(FactoryBot.build(:admin), :dashboard)
expect(policy).to permit(build(:admin), :dashboard)
end
it 'does not grant access to teachers' do
expect(policy).not_to permit(FactoryBot.build(:teacher), :dashboard)
expect(policy).not_to permit(build(:teacher), :dashboard)
end
it 'does not grant access to external users' do
expect(policy).not_to permit(FactoryBot.build(:external_user), :dashboard)
expect(policy).not_to permit(build(:external_user), :dashboard)
end
end
end

16
spec/policies/code_ocean/file_policy_spec.rb
View File

@ -5,15 +5,15 @@ require 'rails_helper'
describe CodeOcean::FilePolicy do
subject(:policy) { described_class }
let(:exercise) { FactoryBot.create(:fibonacci) }
let(:submission) { FactoryBot.create(:submission) }
let(:exercise) { create(:fibonacci) }
let(:submission) { create(:submission) }
permissions :create? do
context 'when being part of an exercise' do
let(:file) { exercise.files.first }
it 'grants access to admins' do
expect(policy).to permit(FactoryBot.build(:admin), file)
expect(policy).to permit(build(:admin), file)
end
it 'grants access to authors' do
@ -22,7 +22,7 @@ describe CodeOcean::FilePolicy do
it 'does not grant access to all other users' do
%i[external_user teacher].each do |factory_name|
expect(policy).not_to permit(FactoryBot.build(factory_name), file)
expect(policy).not_to permit(build(factory_name), file)
end
end
end
@ -52,7 +52,7 @@ describe CodeOcean::FilePolicy do
it 'does not grant access to all other users' do
%i[admin external_user teacher].each do |factory_name|
expect(policy).not_to permit(FactoryBot.build(factory_name), file)
expect(policy).not_to permit(build(factory_name), file)
end
end
end
@ -63,7 +63,7 @@ describe CodeOcean::FilePolicy do
let(:file) { exercise.files.first }
it 'grants access to admins' do
expect(policy).to permit(FactoryBot.build(:admin), file)
expect(policy).to permit(build(:admin), file)
end
it 'grants access to authors' do
@ -72,7 +72,7 @@ describe CodeOcean::FilePolicy do
it 'does not grant access to all other users' do
%i[external_user teacher].each do |factory_name|
expect(policy).not_to permit(FactoryBot.build(factory_name), file)
expect(policy).not_to permit(build(factory_name), file)
end
end
end
@ -82,7 +82,7 @@ describe CodeOcean::FilePolicy do
it 'does not grant access to anyone' do
%i[admin external_user teacher].each do |factory_name|
expect(policy).not_to permit(FactoryBot.build(factory_name), file)
expect(policy).not_to permit(build(factory_name), file)
end
end
end

14
spec/policies/codeharbor_link_policy_spec.rb
View File

@ -5,7 +5,7 @@ require 'rails_helper'
describe CodeharborLinkPolicy do
subject(:policy) { described_class }
let(:codeharbor_link) { FactoryBot.create(:codeharbor_link) }
let(:codeharbor_link) { create(:codeharbor_link) }
context 'when CodeHarbor link is enabled' do
let(:codeocean_config) { instance_double(CodeOcean::Config) }
@ -20,7 +20,7 @@ describe CodeharborLinkPolicy do
permissions(action) do
it 'does not grant access any user' do
%i[external_user teacher admin].each do |factory_name|
expect(policy).not_to permit(FactoryBot.create(factory_name), codeharbor_link)
expect(policy).not_to permit(create(factory_name), codeharbor_link)
end
end
end
@ -30,12 +30,12 @@ describe CodeharborLinkPolicy do
permissions(action) do
it 'grants access to teachers' do
%i[teacher admin].each do |factory_name|
expect(policy).to permit(FactoryBot.create(factory_name), codeharbor_link)
expect(policy).to permit(create(factory_name), codeharbor_link)
end
end
it 'does not grant access to all other users' do
expect(policy).not_to permit(FactoryBot.create(:external_user), codeharbor_link)
expect(policy).not_to permit(create(:external_user), codeharbor_link)
end
end
end
@ -48,7 +48,7 @@ describe CodeharborLinkPolicy do
it 'does not grant access to arbitrary users' do
%i[external_user admin teacher].each do |factory_name|
expect(policy).not_to permit(FactoryBot.create(factory_name), codeharbor_link)
expect(policy).not_to permit(create(factory_name), codeharbor_link)
end
end
end
@ -57,7 +57,7 @@ describe CodeharborLinkPolicy do
permissions(:enabled?) do
it 'reflects the config option' do
%i[external_user admin teacher].each do |factory_name|
expect(policy).to permit(FactoryBot.create(factory_name), codeharbor_link)
expect(policy).to permit(create(factory_name), codeharbor_link)
end
end
end
@ -75,7 +75,7 @@ describe CodeharborLinkPolicy do
permissions(:enabled?) do
it 'reflects the config option' do
%i[external_user admin teacher].each do |factory_name|
expect(policy).not_to permit(FactoryBot.create(factory_name), codeharbor_link)
expect(policy).not_to permit(create(factory_name), codeharbor_link)
end
end
end

4
spec/policies/consumer_policy_spec.rb
View File

@ -8,9 +8,9 @@ describe ConsumerPolicy do
%i[create? destroy? edit? index? new? show? update?].each do |action|
permissions(action) do
it 'grants access to admins only' do
expect(policy).to permit(FactoryBot.build(:admin), Consumer.new)
expect(policy).to permit(build(:admin), Consumer.new)
%i[external_user teacher].each do |factory_name|
expect(policy).not_to permit(FactoryBot.build(factory_name), Consumer.new)
expect(policy).not_to permit(build(factory_name), Consumer.new)
end
end
end

20
spec/policies/execution_environment_policy_spec.rb
View File

@ -5,20 +5,20 @@ require 'rails_helper'
describe ExecutionEnvironmentPolicy do
subject(:policy) { described_class }
let(:execution_environment) { FactoryBot.build(:ruby) }
let(:execution_environment) { build(:ruby) }
[:index?].each do |action|
permissions(action) do
it 'grants access to admins' do
expect(policy).to permit(FactoryBot.build(:admin), execution_environment)
expect(policy).to permit(build(:admin), execution_environment)
end
it 'grants access to teachers' do
expect(policy).to permit(FactoryBot.build(:teacher), execution_environment)
expect(policy).to permit(build(:teacher), execution_environment)
end
it 'does not grant access to external users' do
expect(policy).not_to permit(FactoryBot.build(:external_user), execution_environment)
expect(policy).not_to permit(build(:external_user), execution_environment)
end
end
end
@ -26,7 +26,7 @@ describe ExecutionEnvironmentPolicy do
%i[execute_command? shell? statistics? show?].each do |action|
permissions(action) do
it 'grants access to admins' do
expect(policy).to permit(FactoryBot.build(:admin), execution_environment)
expect(policy).to permit(build(:admin), execution_environment)
end
it 'grants access to authors' do
@ -35,7 +35,7 @@ describe ExecutionEnvironmentPolicy do
it 'does not grant access to all other users' do
%i[external_user teacher].each do |factory_name|
expect(policy).not_to permit(FactoryBot.build(factory_name), execution_environment)
expect(policy).not_to permit(build(factory_name), execution_environment)
end
end
end
@ -44,7 +44,7 @@ describe ExecutionEnvironmentPolicy do
%i[destroy? edit? update? new? create?].each do |action|
permissions(action) do
it 'grants access to admins' do
expect(policy).to permit(FactoryBot.build(:admin), execution_environment)
expect(policy).to permit(build(:admin), execution_environment)
end
it 'does not grant access to authors' do
@ -53,7 +53,7 @@ describe ExecutionEnvironmentPolicy do
it 'does not grant access to all other users' do
%i[external_user teacher].each do |factory_name|
expect(policy).not_to permit(FactoryBot.build(factory_name), execution_environment)
expect(policy).not_to permit(build(factory_name), execution_environment)
end
end
end
@ -61,7 +61,7 @@ describe ExecutionEnvironmentPolicy do
permissions(:sync_all_to_runner_management?) do
it 'grants access to the admin' do
expect(policy).to permit(FactoryBot.build(:admin))
expect(policy).to permit(build(:admin))
end
shared_examples 'it does not grant access' do |user|
@ -71,7 +71,7 @@ describe ExecutionEnvironmentPolicy do
end
%i[teacher external_user].each do |user|
include_examples 'it does not grant access', FactoryBot.build(user)
include_examples 'it does not grant access', FactoryBot.build(user) # rubocop:disable RSpec/FactoryBot/SyntaxMethods
end
end
end

38
spec/policies/exercise_policy_spec.rb
View File

@ -5,13 +5,13 @@ require 'rails_helper'
describe ExercisePolicy do
subject(:policy) { described_class }
let(:exercise) { FactoryBot.build(:dummy, public: true) }
let(:exercise) { build(:dummy, public: true) }
permissions :batch_update? do
it 'grants access to admins only' do
expect(policy).to permit(FactoryBot.build(:admin), exercise)
expect(policy).to permit(build(:admin), exercise)
%i[external_user teacher].each do |factory_name|
expect(policy).not_to permit(FactoryBot.build(factory_name), exercise)
expect(policy).not_to permit(build(factory_name), exercise)
end
end
end
@ -19,15 +19,15 @@ describe ExercisePolicy do
%i[create? index? new? statistics? feedback? rfcs_for_exercise?].each do |action|
permissions(action) do
it 'grants access to admins' do
expect(policy).to permit(FactoryBot.build(:admin), exercise)
expect(policy).to permit(build(:admin), exercise)
end
it 'grants access to teachers' do
expect(policy).to permit(FactoryBot.build(:teacher), exercise)
expect(policy).to permit(build(:teacher), exercise)
end
it 'does not grant access to external users' do
expect(policy).not_to permit(FactoryBot.build(:external_user), exercise)
expect(policy).not_to permit(build(:external_user), exercise)
end
end
end
@ -35,7 +35,7 @@ describe ExercisePolicy do
%i[clone? destroy? edit? update?].each do |action|
permissions(action) do
it 'grants access to admins' do
expect(policy).to permit(FactoryBot.build(:admin), exercise)
expect(policy).to permit(build(:admin), exercise)
end
it 'grants access to authors' do
@ -44,7 +44,7 @@ describe ExercisePolicy do
it 'does not grant access to all other users' do
%i[external_user teacher].each do |factory_name|
expect(policy).not_to permit(FactoryBot.build(factory_name), exercise)
expect(policy).not_to permit(build(factory_name), exercise)
end
end
end
@ -60,7 +60,7 @@ describe ExercisePolicy do
end
context 'when user has codeharbor_link' do
before { user.codeharbor_link = FactoryBot.build(:codeharbor_link) }
before { user.codeharbor_link = build(:codeharbor_link) }
it 'grants access' do
expect(policy).to permit(user, exercise)
@ -69,14 +69,14 @@ describe ExercisePolicy do
end
context 'when user is admin' do
let(:user) { FactoryBot.build(:admin) }
let(:user) { build(:admin) }
it 'does not grant access' do
expect(policy).not_to permit(user, exercise)
end
context 'when user has codeharbor_link' do
before { user.codeharbor_link = FactoryBot.build(:codeharbor_link) }
before { user.codeharbor_link = build(:codeharbor_link) }
it 'grants access' do
expect(policy).to permit(user, exercise)
@ -86,14 +86,14 @@ describe ExercisePolicy do
%i[external_user teacher].each do |factory_name|
context "when user is #{factory_name}" do
let(:user) { FactoryBot.build(factory_name) }
let(:user) { build(factory_name) }
it 'does not grant access' do
expect(policy).not_to permit(user, exercise)
end
context 'when user has codeharbor_link' do
before { user.codeharbor_link = FactoryBot.build(:codeharbor_link) }
before { user.codeharbor_link = build(:codeharbor_link) }
it 'does not grant access' do
expect(policy).not_to permit(user, exercise)
@ -107,7 +107,7 @@ describe ExercisePolicy do
[:show?].each do |action|
permissions(action) do
it 'not grants access to external users' do
expect(policy).not_to permit(FactoryBot.build(:external_user), exercise)
expect(policy).not_to permit(build(:external_user), exercise)
end
end
end
@ -116,7 +116,7 @@ describe ExercisePolicy do
permissions(action) do
it 'grants access to anyone' do
%i[admin external_user teacher].each do |factory_name|
expect(policy).to permit(FactoryBot.build(factory_name), Exercise.new)
expect(policy).to permit(build(factory_name), Exercise.new)
end
end
end
@ -124,14 +124,14 @@ describe ExercisePolicy do
describe ExercisePolicy::Scope do
describe '#resolve' do
let(:admin) { FactoryBot.create(:admin) }
let(:external_user) { FactoryBot.create(:external_user) }
let(:teacher) { FactoryBot.create(:teacher) }
let(:admin) { create(:admin) }
let(:external_user) { create(:external_user) }
let(:teacher) { create(:teacher) }
before do
[admin, teacher].each do |user|
[true, false].each do |public|
FactoryBot.create(:dummy, public: public, user_id: user.id, user_type: InternalUser.name)
create(:dummy, public: public, user_id: user.id, user_type: InternalUser.name)
end
end
end

10
spec/policies/external_user_policy_spec.rb
View File

@ -8,9 +8,9 @@ describe ExternalUserPolicy do
%i[create? destroy? edit? new? show? update?].each do |action|
permissions(action) do
it 'grants access to admins only' do
expect(policy).to permit(FactoryBot.build(:admin), ExternalUser.new)
expect(policy).to permit(build(:admin), ExternalUser.new)
%i[external_user teacher].each do |factory_name|
expect(policy).not_to permit(FactoryBot.build(factory_name), ExternalUser.new)
expect(policy).not_to permit(build(factory_name), ExternalUser.new)
end
end
end
@ -19,10 +19,10 @@ describe ExternalUserPolicy do
[:index?].each do |action|
permissions(action) do
it 'grants access to admins and teachers only' do
expect(policy).to permit(FactoryBot.build(:admin), ExternalUser.new)
expect(policy).to permit(FactoryBot.build(:teacher), ExternalUser.new)
expect(policy).to permit(build(:admin), ExternalUser.new)
expect(policy).to permit(build(:teacher), ExternalUser.new)
[:external_user].each do |factory_name|
expect(policy).not_to permit(FactoryBot.build(factory_name), ExternalUser.new)
expect(policy).not_to permit(build(factory_name), ExternalUser.new)
end
end
end

6
spec/policies/file_type_policy_spec.rb
View File

@ -5,12 +5,12 @@ require 'rails_helper'
describe FileTypePolicy do
subject(:policy) { described_class }
let(:file_type) { FactoryBot.build(:dot_rb) }
let(:file_type) { build(:dot_rb) }
%i[destroy? edit? update? new? create? index? show?].each do |action|
permissions(action) do
it 'grants access to admins' do
expect(policy).to permit(FactoryBot.build(:admin), file_type)
expect(policy).to permit(build(:admin), file_type)
end
it 'grants access to authors' do
@ -19,7 +19,7 @@ describe FileTypePolicy do
it 'does not grant access to all other users' do
%i[external_user teacher].each do |factory_name|
expect(policy).not_to permit(FactoryBot.build(factory_name), file_type)
expect(policy).not_to permit(build(factory_name), file_type)
end
end
end

10
spec/policies/internal_user_policy_spec.rb
View File

@ -8,9 +8,9 @@ describe InternalUserPolicy do
%i[create? edit? index? new? show? update?].each do |action|
permissions(action) do
it 'grants access to admins only' do
expect(policy).to permit(FactoryBot.build(:admin), InternalUser.new)
expect(policy).to permit(build(:admin), InternalUser.new)
%i[external_user teacher].each do |factory_name|
expect(policy).not_to permit(FactoryBot.build(factory_name), InternalUser.new)
expect(policy).not_to permit(build(factory_name), InternalUser.new)
end
end
end
@ -20,16 +20,16 @@ describe InternalUserPolicy do
context 'with an admin user' do
it 'grants access to no one' do
%i[admin external_user teacher].each do |factory_name|
expect(policy).not_to permit(FactoryBot.build(factory_name), FactoryBot.build(:admin))
expect(policy).not_to permit(build(factory_name), build(:admin))
end
end
end
context 'with a non-admin user' do
it 'grants access to admins only' do
expect(policy).to permit(FactoryBot.build(:admin), InternalUser.new)
expect(policy).to permit(build(:admin), InternalUser.new)
%i[external_user teacher].each do |factory_name|
expect(policy).not_to permit(FactoryBot.build(factory_name), FactoryBot.build(:teacher))
expect(policy).not_to permit(build(factory_name), build(:teacher))
end
end
end

12
spec/policies/submission_policy_spec.rb
View File

@ -8,7 +8,7 @@ describe SubmissionPolicy do
permissions :create? do
it 'grants access to anyone' do
%i[admin external_user teacher].each do |factory_name|
expect(policy).to permit(FactoryBot.build(factory_name), Submission.new)
expect(policy).to permit(build(factory_name), Submission.new)
end
end
end
@ -16,21 +16,21 @@ describe SubmissionPolicy do
%i[download_file? render_file? run? score? show? statistics? stop? test?].each do |action|
permissions(action) do
it 'grants access to admins' do
expect(policy).to permit(FactoryBot.build(:admin), Submission.new)
expect(policy).to permit(build(:admin), Submission.new)
end
it 'grants access to authors' do
user = FactoryBot.create(:external_user)
expect(policy).to permit(user, FactoryBot.build(:submission, exercise: Exercise.new, user_id: user.id, user_type: user.class.name))
user = create(:external_user)
expect(policy).to permit(user, build(:submission, exercise: Exercise.new, user_id: user.id, user_type: user.class.name))
end
end
end
permissions :index? do
it 'grants access to admins only' do
expect(policy).to permit(FactoryBot.build(:admin), Submission.new)
expect(policy).to permit(build(:admin), Submission.new)
%i[external_user teacher].each do |factory_name|
expect(policy).not_to permit(FactoryBot.build(factory_name), Submission.new)
expect(policy).not_to permit(build(factory_name), Submission.new)
end
end
end