htwkmooc/codeocean
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Update bundle (with newest rubocop version) and fix offenses

Browse Source
This commit is contained in:
Sebastian Serth
2022-01-03 18:11:17 +01:00
parent 57e32611ed
commit ea85519163
93 changed files with 968 additions and 985 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
spec/policies/codeharbor_link_policy_spec.rb
View File

@ -5,7 +5,7 @@ require 'rails_helper'
describe CodeharborLinkPolicy do
subject(:policy) { described_class }
let(:codeharbor_link) { FactoryBot.create(:codeharbor_link) }
let(:codeharbor_link) { create(:codeharbor_link) }
context 'when CodeHarbor link is enabled' do
let(:codeocean_config) { instance_double(CodeOcean::Config) }
@ -20,7 +20,7 @@ describe CodeharborLinkPolicy do
permissions(action) do
it 'does not grant access any user' do
%i[external_user teacher admin].each do |factory_name|
expect(policy).not_to permit(FactoryBot.create(factory_name), codeharbor_link)
expect(policy).not_to permit(create(factory_name), codeharbor_link)
end
end
end
@ -30,12 +30,12 @@ describe CodeharborLinkPolicy do
permissions(action) do
it 'grants access to teachers' do
%i[teacher admin].each do |factory_name|
expect(policy).to permit(FactoryBot.create(factory_name), codeharbor_link)
expect(policy).to permit(create(factory_name), codeharbor_link)
end
end
it 'does not grant access to all other users' do
expect(policy).not_to permit(FactoryBot.create(:external_user), codeharbor_link)
expect(policy).not_to permit(create(:external_user), codeharbor_link)
end
end
end
@ -48,7 +48,7 @@ describe CodeharborLinkPolicy do
it 'does not grant access to arbitrary users' do
%i[external_user admin teacher].each do |factory_name|
expect(policy).not_to permit(FactoryBot.create(factory_name), codeharbor_link)
expect(policy).not_to permit(create(factory_name), codeharbor_link)
end
end
end
@ -57,7 +57,7 @@ describe CodeharborLinkPolicy do
permissions(:enabled?) do
it 'reflects the config option' do
%i[external_user admin teacher].each do |factory_name|
expect(policy).to permit(FactoryBot.create(factory_name), codeharbor_link)
expect(policy).to permit(create(factory_name), codeharbor_link)
end
end
end
@ -75,7 +75,7 @@ describe CodeharborLinkPolicy do
permissions(:enabled?) do
it 'reflects the config option' do
%i[external_user admin teacher].each do |factory_name|
expect(policy).not_to permit(FactoryBot.create(factory_name), codeharbor_link)
expect(policy).not_to permit(create(factory_name), codeharbor_link)
end
end
end