Update bundle (with newest rubocop version) and fix offenses

This commit is contained in:
Sebastian Serth
2022-01-03 18:11:17 +01:00
parent 57e32611ed
commit ea85519163
93 changed files with 968 additions and 985 deletions

View File

@ -5,20 +5,20 @@ require 'rails_helper'
describe ExecutionEnvironmentPolicy do
subject(:policy) { described_class }
let(:execution_environment) { FactoryBot.build(:ruby) }
let(:execution_environment) { build(:ruby) }
[:index?].each do |action|
permissions(action) do
it 'grants access to admins' do
expect(policy).to permit(FactoryBot.build(:admin), execution_environment)
expect(policy).to permit(build(:admin), execution_environment)
end
it 'grants access to teachers' do
expect(policy).to permit(FactoryBot.build(:teacher), execution_environment)
expect(policy).to permit(build(:teacher), execution_environment)
end
it 'does not grant access to external users' do
expect(policy).not_to permit(FactoryBot.build(:external_user), execution_environment)
expect(policy).not_to permit(build(:external_user), execution_environment)
end
end
end
@ -26,7 +26,7 @@ describe ExecutionEnvironmentPolicy do
%i[execute_command? shell? statistics? show?].each do |action|
permissions(action) do
it 'grants access to admins' do
expect(policy).to permit(FactoryBot.build(:admin), execution_environment)
expect(policy).to permit(build(:admin), execution_environment)
end
it 'grants access to authors' do
@ -35,7 +35,7 @@ describe ExecutionEnvironmentPolicy do
it 'does not grant access to all other users' do
%i[external_user teacher].each do |factory_name|
expect(policy).not_to permit(FactoryBot.build(factory_name), execution_environment)
expect(policy).not_to permit(build(factory_name), execution_environment)
end
end
end
@ -44,7 +44,7 @@ describe ExecutionEnvironmentPolicy do
%i[destroy? edit? update? new? create?].each do |action|
permissions(action) do
it 'grants access to admins' do
expect(policy).to permit(FactoryBot.build(:admin), execution_environment)
expect(policy).to permit(build(:admin), execution_environment)
end
it 'does not grant access to authors' do
@ -53,7 +53,7 @@ describe ExecutionEnvironmentPolicy do
it 'does not grant access to all other users' do
%i[external_user teacher].each do |factory_name|
expect(policy).not_to permit(FactoryBot.build(factory_name), execution_environment)
expect(policy).not_to permit(build(factory_name), execution_environment)
end
end
end
@ -61,7 +61,7 @@ describe ExecutionEnvironmentPolicy do
permissions(:sync_all_to_runner_management?) do
it 'grants access to the admin' do
expect(policy).to permit(FactoryBot.build(:admin))
expect(policy).to permit(build(:admin))
end
shared_examples 'it does not grant access' do |user|
@ -71,7 +71,7 @@ describe ExecutionEnvironmentPolicy do
end
%i[teacher external_user].each do |user|
include_examples 'it does not grant access', FactoryBot.build(user)
include_examples 'it does not grant access', FactoryBot.build(user) # rubocop:disable RSpec/FactoryBot/SyntaxMethods
end
end
end