Update bundle (with newest rubocop version) and fix offenses

This commit is contained in:
Sebastian Serth
2022-01-03 18:11:17 +01:00
parent 57e32611ed
commit ea85519163
93 changed files with 968 additions and 985 deletions

View File

@ -8,7 +8,7 @@ describe SubmissionPolicy do
permissions :create? do
it 'grants access to anyone' do
%i[admin external_user teacher].each do |factory_name|
expect(policy).to permit(FactoryBot.build(factory_name), Submission.new)
expect(policy).to permit(build(factory_name), Submission.new)
end
end
end
@ -16,21 +16,21 @@ describe SubmissionPolicy do
%i[download_file? render_file? run? score? show? statistics? stop? test?].each do |action|
permissions(action) do
it 'grants access to admins' do
expect(policy).to permit(FactoryBot.build(:admin), Submission.new)
expect(policy).to permit(build(:admin), Submission.new)
end
it 'grants access to authors' do
user = FactoryBot.create(:external_user)
expect(policy).to permit(user, FactoryBot.build(:submission, exercise: Exercise.new, user_id: user.id, user_type: user.class.name))
user = create(:external_user)
expect(policy).to permit(user, build(:submission, exercise: Exercise.new, user_id: user.id, user_type: user.class.name))
end
end
end
permissions :index? do
it 'grants access to admins only' do
expect(policy).to permit(FactoryBot.build(:admin), Submission.new)
expect(policy).to permit(build(:admin), Submission.new)
%i[external_user teacher].each do |factory_name|
expect(policy).not_to permit(FactoryBot.build(factory_name), Submission.new)
expect(policy).not_to permit(build(factory_name), Submission.new)
end
end
end