From 815d7004811e316acf3757fbd3987c8c662e19fe Mon Sep 17 00:00:00 2001 From: Maximilian Grundke Date: Fri, 13 Jul 2018 09:43:06 +0200 Subject: [PATCH] Reject nil values in working times --- lib/tasks/detect_exercise_anomalies.rake | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/lib/tasks/detect_exercise_anomalies.rake b/lib/tasks/detect_exercise_anomalies.rake index 384b6066..be4ff161 100644 --- a/lib/tasks/detect_exercise_anomalies.rake +++ b/lib/tasks/detect_exercise_anomalies.rake @@ -71,10 +71,9 @@ namespace :detect_exercise_anomalies do end def find_anomalies(collection) - working_times = collect_working_times(collection) - values = working_times.values.reject {|value| value.nil?} - if values.size > 0 - average = values.reduce(:+) / values.size + working_times = collect_working_times(collection).reject {|_, value| value.nil?} + if working_times.size > 0 + average = working_times.reduce(:+) / working_times.size return working_times.select do |_, working_time| working_time > average * MAX_TIME_FACTOR or working_time < average * MIN_TIME_FACTOR end