From f38052d235185b72a853131e1262016a8d6c88f9 Mon Sep 17 00:00:00 2001
From: Sebastian Serth <Sebastian.Serth@hpi.de>
Date: Fri, 12 Aug 2022 18:01:47 +0200
Subject: [PATCH] Allow fa-spin to spin, actually

When using `display: inline;`, many browsers won't rotate the icon.
---
 app/assets/javascripts/editor/editor.js.erb  | 4 ++--
 app/assets/stylesheets/editor.css.scss       | 4 ----
 app/views/exercises/_editor_button.html.slim | 2 +-
 3 files changed, 3 insertions(+), 7 deletions(-)

diff --git a/app/assets/javascripts/editor/editor.js.erb b/app/assets/javascripts/editor/editor.js.erb
index d242e64b..8040c308 100644
--- a/app/assets/javascripts/editor/editor.js.erb
+++ b/app/assets/javascripts/editor/editor.js.erb
@@ -217,7 +217,7 @@ var CodeOceanEditor = {
 
     hideSpinner: function () {
         $('button i.fa-solid, button i.fa-regular').show();
-        $('button i.fa-spin').hide();
+        $('button i.fa-spin').removeClass('d-inline-block').addClass('d-none');
     },
 
 
@@ -704,7 +704,7 @@ var CodeOceanEditor = {
 
     showSpinner: function (initiator) {
         $(initiator).find('i.fa-solid, i.fa-regular').hide();
-        $(initiator).find('i.fa-spin').show();
+        $(initiator).find('i.fa-spin').addClass('d-inline-block').removeClass('d-none');
     },
 
     showStatus: function (output) {
diff --git a/app/assets/stylesheets/editor.css.scss b/app/assets/stylesheets/editor.css.scss
index fc564439..7d2ae714 100644
--- a/app/assets/stylesheets/editor.css.scss
+++ b/app/assets/stylesheets/editor.css.scss
@@ -1,7 +1,3 @@
-button i.fa-spin {
-  display: none;
-}
-
 .editor {
   height: 100%;
   width: 100%;
diff --git a/app/views/exercises/_editor_button.html.slim b/app/views/exercises/_editor_button.html.slim
index 2608e65e..c3370f29 100644
--- a/app/views/exercises/_editor_button.html.slim
+++ b/app/views/exercises/_editor_button.html.slim
@@ -1,4 +1,4 @@
 button.btn class=local_assigns.fetch(:classes, 'btn-primary') *local_assigns.fetch(:data, {}) disabled=local_assigns.fetch(:disabled, false) id=id title=local_assigns[:title] type='button'
-  i.fa-solid.fa-circle-notch.fa-spin class=(label.blank? ? "m-0" : '')
+  i.fa-solid.fa-circle-notch.fa-spin.d-none class=(label.blank? ? "m-0" : '')
   i class=(label.present? ? icon : "#{icon} m-0")
   = label