htwkmooc/codeocean
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

directly call proc (before execution block) and rescue from an exception if it happens instead of using try, in order to log the error.

Browse Source
This commit is contained in:
Ralf Teusner
2015-12-16 16:30:54 +01:00
parent 8e90fbac26
commit f928874189
1 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
lib/docker_client.rb
View File

@ -168,7 +168,13 @@ class DockerClient
@container = DockerContainerPool.get_container(@execution_environment) @container = DockerContainerPool.get_container(@execution_environment)
if @container if @container
@container.status = :executing @container.status = :executing
before_execution_block.try(:call) # do not use try here, directly call the passed proc and rescue from the error in order to log the problem.
#before_execution_block.try(:call)
begin
before_execution_block.call
rescue StandardError => error
Rails.logger.error('execute_websocket_command: Rescued from StandardError caused by before_execution_block.call: ' + error.to_s)
end
# TODO: catch exception if socket could not be created # TODO: catch exception if socket could not be created
@socket ||= create_socket(@container) @socket ||= create_socket(@container)
# Newline required to flush # Newline required to flush