From f98a8b9e7a70c1dff207d49d0671688dd1931168 Mon Sep 17 00:00:00 2001
From: Felix Auringer <48409110+felixauringer@users.noreply.github.com>
Date: Thu, 1 Jul 2021 13:52:05 +0200
Subject: [PATCH] Resolve error handling todos in dcp strategy

---
 lib/runner/strategy/docker_container_pool.rb | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/lib/runner/strategy/docker_container_pool.rb b/lib/runner/strategy/docker_container_pool.rb
index 2a8026a4..9dce17df 100644
--- a/lib/runner/strategy/docker_container_pool.rb
+++ b/lib/runner/strategy/docker_container_pool.rb
@@ -38,8 +38,6 @@ class Runner::Strategy::DockerContainerPool < Runner::Strategy
         begin
           File.open(local_file_path, 'w') {|f| f.write(file.content) }
         rescue IOError => e
-          # TODO: try catch i/o exception and log failed attempts
-          # Does this fix the issue @Sebastian? What exceptions did you have in mind?
           raise Runner::Error::WorkspaceError.new("Could not create file #{file.filepath}: #{e.inspect}")
         end
       end
@@ -99,7 +97,6 @@ class Runner::Strategy::DockerContainerPool < Runner::Strategy
   rescue Errno::ENOENT => e
     raise Runner::Error::WorkspaceError.new("The workspace directory does not exist and cannot be deleted: #{e.inspect}")
   rescue Errno::EACCES => e
-    # TODO: Why was this rescued before @Sebastian?
     raise Runner::Error::WorkspaceError.new("Not allowed to clean workspace #{local_workspace_path}: #{e.inspect}")
   end